Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Oct 2015 13:42:48 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r289664 - head/sys/kern
Message-ID:  <5626A748.5040101@FreeBSD.org>
In-Reply-To: <201510202038.t9KKcKW5064373@repo.freebsd.org>
References:  <201510202038.t9KKcKW5064373@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 10/20/2015 1:38 PM, Konstantin Belousov wrote:
> Author: kib
> Date: Tue Oct 20 20:38:20 2015
> New Revision: 289664
> URL: https://svnweb.freebsd.org/changeset/base/289664
>=20
> Log:
>   Trim spaces at end of line to record the proper commit message for
>   r289660:
>  =20
>   Do not allow to execute ptrace(PT_TRACE_ME) when the process is
>   already traced.
>  =20
>   Do not allow to execute ptrace(PT_TRACE_ME) when there is no parent
>   which can trace the process, i.e. when the parent is already init.
>   Note that after the PT_TRACE_ME request the process is unkillable and=

>   non-continuable until a debugger is attached, or parent is killed, th=
e
>   later clears P_TRACED state.  Since init clearly would not debug the
>   caller, and cannot be killed, disallow creation of unkillable
>   processes.
>  =20
>   Reviewed by:	jhb, pho
>   Reported and tested by:	pho
>   Sponsored by:	The FreeBSD Foundation
>   MFC after:	2 weeks
>   Differential revision:	https://reviews.freebsd.org/D3908
>=20
> Modified:
>   head/sys/kern/sys_process.c
>=20
> Modified: head/sys/kern/sys_process.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/kern/sys_process.c	Tue Oct 20 20:37:00 2015	(r289663)
> +++ head/sys/kern/sys_process.c	Tue Oct 20 20:38:20 2015	(r289664)
> @@ -443,7 +443,7 @@ ptrace_vm_entry(struct thread *td, struc
>  }
> =20
>  #ifdef COMPAT_FREEBSD32
> -static int     =20
> +static int
>  ptrace_vm_entry32(struct thread *td, struct proc *p,
>      struct ptrace_vm_entry32 *pve32)
>  {
>=20

I really think we should just do a full revert and recommit in these
cases, and not even a forced commit.  Neither this commit or a forced
commit will show in 'svn blame' or even during a bisect.  It really just
becomes luck to find the right commit noting the message.  IMHO 'svn
blame' is more important than some extra churn in 'svn log' or email. It
does add more steps in 'svn blame' but it ends up giving the right
message more obviously.

I'm not asking to redo this commit now, but I think we should have a
standard of just recommitting to fix mistakes.

--=20
Regards,
Bryan Drewery


--mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWJqdIAAoJEDXXcbtuRpfPaiEH+wYeDnFa8NOztiK81QdSwtvK
l6V9dWcO9bToySKGDbozY48xBaEvkW0ofB0MSafsmr756LDAmGGUqwULJkSmGlfH
QKWtNnzDDFOyxmVUWFnDOhOPjZm3X8+zcZyxBLH/WG2bhLJyjir8OklQY+sydyOE
ls8jBY+XeF+7erFCG0oatoNf/NR6TtRxw6YRDatJFdCO7E1eNc9A72Md5sSl2hFh
oDQjpWJTC9ZVvhb5FyV/iHAJsHHbpnDh6GZAfY9BImvxGondU2lPnDK13Y/oHNT0
+OugV8m5Jh4/FPYKSIZ2YTkH1I7QTq+UxqQ+t15e1o4J84sHnmqwn73D9oN/mkI=
=xnWE
-----END PGP SIGNATURE-----

--mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5626A748.5040101>