From owner-svn-src-all@freebsd.org Tue Oct 20 20:42:51 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBE4AA0AAF2; Tue, 20 Oct 2015 20:42:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9CBF219A0; Tue, 20 Oct 2015 20:42:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 959D71CB6; Tue, 20 Oct 2015 20:42:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 4F57F163C9; Tue, 20 Oct 2015 20:42:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id ZugAx69UmTr1; Tue, 20 Oct 2015 20:42:48 +0000 (UTC) Subject: Re: svn commit: r289664 - head/sys/kern DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com BA2D7163C4 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201510202038.t9KKcKW5064373@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5626A748.5040101@FreeBSD.org> Date: Tue, 20 Oct 2015 13:42:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <201510202038.t9KKcKW5064373@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 20:42:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/20/2015 1:38 PM, Konstantin Belousov wrote: > Author: kib > Date: Tue Oct 20 20:38:20 2015 > New Revision: 289664 > URL: https://svnweb.freebsd.org/changeset/base/289664 >=20 > Log: > Trim spaces at end of line to record the proper commit message for > r289660: > =20 > Do not allow to execute ptrace(PT_TRACE_ME) when the process is > already traced. > =20 > Do not allow to execute ptrace(PT_TRACE_ME) when there is no parent > which can trace the process, i.e. when the parent is already init. > Note that after the PT_TRACE_ME request the process is unkillable and= > non-continuable until a debugger is attached, or parent is killed, th= e > later clears P_TRACED state. Since init clearly would not debug the > caller, and cannot be killed, disallow creation of unkillable > processes. > =20 > Reviewed by: jhb, pho > Reported and tested by: pho > Sponsored by: The FreeBSD Foundation > MFC after: 2 weeks > Differential revision: https://reviews.freebsd.org/D3908 >=20 > Modified: > head/sys/kern/sys_process.c >=20 > Modified: head/sys/kern/sys_process.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/sys_process.c Tue Oct 20 20:37:00 2015 (r289663) > +++ head/sys/kern/sys_process.c Tue Oct 20 20:38:20 2015 (r289664) > @@ -443,7 +443,7 @@ ptrace_vm_entry(struct thread *td, struc > } > =20 > #ifdef COMPAT_FREEBSD32 > -static int =20 > +static int > ptrace_vm_entry32(struct thread *td, struct proc *p, > struct ptrace_vm_entry32 *pve32) > { >=20 I really think we should just do a full revert and recommit in these cases, and not even a forced commit. Neither this commit or a forced commit will show in 'svn blame' or even during a bisect. It really just becomes luck to find the right commit noting the message. IMHO 'svn blame' is more important than some extra churn in 'svn log' or email. It does add more steps in 'svn blame' but it ends up giving the right message more obviously. I'm not asking to redo this commit now, but I think we should have a standard of just recommitting to fix mistakes. --=20 Regards, Bryan Drewery --mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWJqdIAAoJEDXXcbtuRpfPaiEH+wYeDnFa8NOztiK81QdSwtvK l6V9dWcO9bToySKGDbozY48xBaEvkW0ofB0MSafsmr756LDAmGGUqwULJkSmGlfH QKWtNnzDDFOyxmVUWFnDOhOPjZm3X8+zcZyxBLH/WG2bhLJyjir8OklQY+sydyOE ls8jBY+XeF+7erFCG0oatoNf/NR6TtRxw6YRDatJFdCO7E1eNc9A72Md5sSl2hFh oDQjpWJTC9ZVvhb5FyV/iHAJsHHbpnDh6GZAfY9BImvxGondU2lPnDK13Y/oHNT0 +OugV8m5Jh4/FPYKSIZ2YTkH1I7QTq+UxqQ+t15e1o4J84sHnmqwn73D9oN/mkI= =xnWE -----END PGP SIGNATURE----- --mSBiLJ3puu9mMv5QbcOWHaTeBH4wo5X9K--