Date: Mon, 06 Feb 2017 22:27:01 +0100 From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: Michael Gmelin <freebsd@grem.de> Cc: "freebsd-ports\@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: cmake release builds don't disable assertions (NDEBUG) Message-ID: <86wpd3t3h6.fsf@orwell> In-Reply-To: <20170206180539.43e98408@bsd64.grem.de> (Michael Gmelin's message of "Mon, 6 Feb 2017 18:05:39 %2B0100") References: <20170206180539.43e98408@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Gmelin <freebsd@grem.de> writes: > While debugging an unexpected assertion problem, I noticed that ports > using cmake don't set -NDEBUG, even when building in Release mode. > > Is this intentional? Is it the software you're porting that checks for DEBUG or some library it uses? CMake code should check for CMAKE_BUILD_TYPE and adjust the compiler flags accordingly (if at all); so if the software itself is checking for DEBUG but not passing (or omitting it) I'd say the bug is there, not in Mk/Uses/cmake.mk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86wpd3t3h6.fsf>