From owner-cvs-all@FreeBSD.ORG Thu Sep 29 16:57:13 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FC0516A41F; Thu, 29 Sep 2005 16:57:13 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76D3B43D48; Thu, 29 Sep 2005 16:57:12 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j8TH3lB3022747; Thu, 29 Sep 2005 13:03:47 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Peter Edwards Date: Thu, 29 Sep 2005 12:56:46 -0400 User-Agent: KMail/1.6.2 References: <200509291037.j8TAbKdI010227@repoman.freebsd.org> <200509291200.29735.jkim@FreeBSD.org> <34cb7c8405092909181163c887@mail.gmail.com> In-Reply-To: <34cb7c8405092909181163c887@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200509291256.55435.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1104/Wed Sep 28 18:20:40 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2005 16:57:13 -0000 On Thursday 29 September 2005 12:18 pm, Peter Edwards wrote: > On 9/29/05, Jung-uk Kim wrote: > > On Thursday 29 September 2005 09:03 am, Pawel Jakub Dawidek wrote: > > > On Thu, Sep 29, 2005 at 10:37:20AM +0000, Peter Edwards wrote: > > > +> peadar 2005-09-29 10:37:20 UTC > > > +> > > > +> FreeBSD src repository > > > +> > > > +> Modified files: > > > +> sys/kern vfs_bio.c > > > +> Log: > > > +> Close a race in biodone(), whereby the bio_done field of > > > the passed +> bio may have been freed and reassigned by the > > > wakeup before being +> tested after releasing the bdonelock. > > > +> > > > +> There's a non-zero chance this is the cause of a few of > > > the crashes +> knocking around with biodone() sitting in the > > > stack backtrace. > > > > > > Should this fix the panic on boot in vmware? > > > > I thought that might be it, too. I tried it with 6.0-BETA5 on > > QEMU but no change. :-( > > Ah: If it fails in QEMU, I might be able to reproduce it. FYI, the most reliable way to reproduce is to 'tar tfv BIG_TARBALL' from CD-ROM image. I have been using 16 MB something.tar.bz2 file as a test case. 100% success. BTW, depending on the emulated CD-ROM mode, i. e., DMA or PIO, you will see different crash because of different code path. DMA case: http://www.freebsd.org/cgi/query-pr.cgi?pr=84102 PIO case: http://docs.freebsd.org/cgi/mid.cgi?42C626C9.60206 It seems the similar things happened on real hardware: http://www.freebsd.org/cgi/query-pr.cgi?pr=84568 http://docs.freebsd.org/cgi/mid.cgi?20050921181336.GF72516 I am not sure they are really related but it looks very suspicious. BTW, 5.4 is okay. 5.4 with ATA mkIII patch is okay. 6.0 without PEEMPTION is okay. So, please don't blame it on the emulators. Like sam@ said, it is good tool to find real bugs without causing real damage. ;-) > Do you mean you replaced the 6.0-BETA5 with your own kernel, yes? Correct. Jung-uk Kim