Date: Mon, 4 Mar 2019 16:20:13 -0600 From: Kyle Evans <kevans@freebsd.org> To: Steve Wills <swills@freebsd.org>, alex@xanderio.de Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494657 - head/x11/rofi-pass Message-ID: <CACNAnaHkX3m_Tk56yi_q%2BOA1MFzbQTUMfHrtxfrRLWMbbVi%2B3g@mail.gmail.com> In-Reply-To: <201903042208.x24M8p9x000612@repo.freebsd.org> References: <201903042208.x24M8p9x000612@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 4, 2019 at 4:09 PM Steve Wills <swills@freebsd.org> wrote: > > Author: swills > Date: Mon Mar 4 22:08:50 2019 > New Revision: 494657 > URL: https://svnweb.freebsd.org/changeset/ports/494657 > > Log: > x11/rofi-pass: remove unnecessary dependencies > > PR: 236225 > Submitted by: alex@xanderio.de (maintainer) > Hi, I did a pass over this to make sure it wasn't using grep features that we don't quite support but don't treat as errors -- that turned out alright, but it turns out the sed usage is slightly wrong in one place [1] for our world. I would recommend sending a patch upstream to change this to the more portable expression `sed -Ee 's/[[:blank:]]+$//'`, though it's probably not critical to patch it locally since it just strips whitespace off the end (or doesn't, as the case is now =)). Thanks, Kyle Evans [1] https://github.com/carnager/rofi-pass/blob/master/addpass#L56
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHkX3m_Tk56yi_q%2BOA1MFzbQTUMfHrtxfrRLWMbbVi%2B3g>