From owner-cvs-ports@FreeBSD.ORG Thu Apr 1 06:49:43 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D890106566B for ; Thu, 1 Apr 2010 06:49:43 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id DEB128FC1B for ; Thu, 1 Apr 2010 06:49:42 +0000 (UTC) Received: (qmail 30323 invoked by uid 399); 1 Apr 2010 06:49:41 -0000 Received: from localhost (HELO ?192.168.0.145?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 1 Apr 2010 06:49:41 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Date: Wed, 31 Mar 2010 23:49:39 -0700 (PDT) From: Doug Barton To: Pav Lucistnik In-Reply-To: <201003312058.o2VKwQfV022077@repoman.freebsd.org> Message-ID: References: <201003312058.o2VKwQfV022077@repoman.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://SupersetSolutions.com/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Cc: cvs-ports@FreeBSD.org, janos.mohacsi@bsd.hu, geoffroy desvernay , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/nfsen Makefile ports/net-mgmt/nfsen/files nfsen.in nfsen.sh.in patch-libexec_NfSenRRD.pm X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 06:49:43 -0000 So first off, thanks to geoffroy for taking the time to do this. It's nice to have more of our ports scripts actually making use of the rc.d framework. There are however a couple of problems with the script. The most serious is that all of the examples of "/usr/local" need to be changed to %%PREFIX%% so that if a user has a different prefix set it will still work. There are other elements it would be nice to improve, please see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more information. To the maintainer, can you please approve at least the change to %%PREFIX%% so that we can fix that ASAP? Thanks, Doug On Wed, 31 Mar 2010, Pav Lucistnik wrote: > pav 2010-03-31 20:58:26 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/nfsen Makefile > Added files: > net-mgmt/nfsen/files nfsen.in patch-libexec_NfSenRRD.pm > Removed files: > net-mgmt/nfsen/files nfsen.sh.in > Log: > - Provide rc.subr script > > PR: ports/144384 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144384 > Submitted by: geoffroy desvernay > Approved by: maintainer > > - Allow to work with rrdtool 1.4.x > > PR: ports/144876 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144876 > Submitted by: Vincent Hoffman > Approved by: maintainer > > Revision Changes Path > 1.16 +3 -1 ports/net-mgmt/nfsen/Makefile > 1.1 +24 -0 ports/net-mgmt/nfsen/files/nfsen.in (new) > 1.3 +0 -86 ports/net-mgmt/nfsen/files/nfsen.sh.in (dead) > 1.1 +11 -0 ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/Makefile.diff?&r1=1.15&r2=1.16&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/nfsen.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/nfsen.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm > > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso