From owner-svn-ports-head@freebsd.org Wed Oct 24 13:46:05 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBFABFD9EE0; Wed, 24 Oct 2018 13:46:05 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3867F8F02B; Wed, 24 Oct 2018 13:46:05 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: by mail-lf1-f66.google.com with SMTP id d7-v6so4037289lfi.2; Wed, 24 Oct 2018 06:46:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C/3LwWSvxgZJrAKoaqZr88Vyo5HclfEbDXdFDoSyTW0=; b=sJq3xnrKTLwIbexbbN1hvnGv5E/+joSmN0fF/UkodeuavFkxd02yNoT3fxvF9egBT2 B0cqU/OewGv8ukepH11y4cYxsRiyR71yBkCCyG2QwsawUnmaHV7o9PVAafVTZd5f4GJN COoGEhyBQkfsZbxZtagaoFNz6NQuSmRiaIrZJhVE80tPsx+utAFxsSzx7CPR21TZIXnh xRqmIcAHwsW7NYh9+UkiHdPyJQUTfNIbHW68LPiFpwopjpUHh2ppTc+SxXgTBtF/6Lz1 8u3v4AIpNttaDyy7BrgXps8YMlf3IdvhRnYrlAFmOkQahz0D0b7aBfo5GSLsgPOZIoSO umcA== X-Gm-Message-State: ABuFfoigENbUjfs7sz45A949QUi4nB5HcrbUfxA6AXG3PTRrKPT666UF Q198+o5CSuRmpHohKDfEjsDlsZz4fzU= X-Google-Smtp-Source: ACcGV63oTx3cl/pzPFUPFCI83tbWeheOj2rquM/TCvf/9EdhMTOWMPr7/1Je5+5lTRtiWF0jBaS4fg== X-Received: by 2002:a19:f514:: with SMTP id j20-v6mr14865792lfb.13.1540388758022; Wed, 24 Oct 2018 06:45:58 -0700 (PDT) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id r81-v6sm716576lff.43.2018.10.24.06.45.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Oct 2018 06:45:57 -0700 (PDT) Received: by mail-lf1-f44.google.com with SMTP id p34-v6so4002510lfg.10; Wed, 24 Oct 2018 06:45:57 -0700 (PDT) X-Received: by 2002:a19:d78c:: with SMTP id q12mr3169541lfi.27.1540388757150; Wed, 24 Oct 2018 06:45:57 -0700 (PDT) MIME-Version: 1.0 References: <201810171315.w9HDFrgI039873@repo.freebsd.org> <20181024083541.4q726xezswwqe2xo@atuin.in.mat.cc> In-Reply-To: <20181024083541.4q726xezswwqe2xo@atuin.in.mat.cc> From: Luca Pizzamiglio Date: Wed, 24 Oct 2018 15:45:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r482294 - head/devel/sccache To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 13:46:06 -0000 I tend to disagree. Before this change, I've received pkg_fallout emails. Probably I misused the work "dependency". It's a crate (openssl.0.9.24) that fails to build because of OpenSSL 1.1.1. I've already reported it upstream, but the best way to solve it is not trivial (https://github.com/mozilla/sccache/issues/311) Rust dependencies (crates) are statically linked in the final executable, so if a dependency crate fails to build, the whole application failed to build. Crates are not shared library, they are shared API statically linked to the final executable. security/openssl as runtime dependency will cause conflict with the base one (ld-elf.so.1: /usr/local/lib/libcrypto.so.9: version OPENSSL_1_1_0 required by /usr/local/lib/libpkg.so.4 not defined, for instance) I could use security/openssl as build dependency and let the openssl crate to statically link to it, but I don't like this approach, because at every security/openssl fix, I have to bump portrevision of sccache. Best regards pizzamig@ On Wed, Oct 24, 2018 at 3:23 PM Mathieu Arnold wrote: > On Wed, Oct 17, 2018 at 01:15:53PM +0000, Luca Pizzamiglio wrote: > > Author: pizzamig > > Date: Wed Oct 17 13:15:53 2018 > > New Revision: 482294 > > URL: https://svnweb.freebsd.org/changeset/ports/482294 > > > > Log: > > devel/sccache: ignore on CURRENT if openssl 1.1.1 based > > > > The current chain of dependencies doens't support openssl 1.1.1 > > This change is bobus. First, I think it works just fine on current if > using security/openssl. Also, this port is not incompatible with > openssl 1.1.1, only one of its dependency is, so this is not needed. > > > Modified: > > head/devel/sccache/Makefile > > > > Modified: head/devel/sccache/Makefile > > > ============================================================================== > > --- head/devel/sccache/Makefile Wed Oct 17 13:14:17 2018 > (r482293) > > +++ head/devel/sccache/Makefile Wed Oct 17 13:15:53 2018 > (r482294) > > @@ -282,10 +282,16 @@ CARGO_CRATES= adler32-1.0.3 \ > > xattr-0.2.2 \ > > zip-0.4.2 > > > > +.include > > + > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} > 1200084 > > +IGNORE= openssl 1.1.1 is incompatible with the reqwest 0.8.8 > dependencies > > +.endif > > + > > do-install-DOCS-on: > > @${MKDIR} ${STAGEDIR}${DOCSDIR} > > ${INSTALL_DATA} ${WRKSRC}/README.md ${STAGEDIR}${DOCSDIR} > > > > post-install: > > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/sccache > > -.include > > +.include > > > > > > -- > Mathieu Arnold >