From owner-freebsd-current Sat Nov 9 3:59:36 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3818C37B401 for ; Sat, 9 Nov 2002 03:59:35 -0800 (PST) Received: from snipe.mail.pas.earthlink.net (snipe.mail.pas.earthlink.net [207.217.120.62]) by mx1.FreeBSD.org (Postfix) with ESMTP id D048743E42 for ; Sat, 9 Nov 2002 03:59:34 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0007.cvx22-bradley.dialup.earthlink.net ([209.179.198.7] helo=mindspring.com) by snipe.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 18AUGv-00035q-00; Sat, 09 Nov 2002 03:59:29 -0800 Message-ID: <3DCCF856.66707AA7@mindspring.com> Date: Sat, 09 Nov 2002 03:58:14 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Jeff Roberson Cc: Andrea Campi , current@FreeBSD.ORG Subject: Re: Deadlock during buildworld References: <20021109011822.N14121-100000@mail.chesapeake.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jeff Roberson wrote: [ ... patch ... looks right to me, but I wonder if it opens a race window in the "vput() blocks" case ...either way, it's no worse than the code it replaces... ] > I'll look into it some more, but it looks like someone is holding the exec > map while they are trying to lock that vnode. That doesn't seem correct, > but this patch will fix the problem if that is the case. It's too bad we > dont have witness on lockmgr.. It's too bad that lockmgr() is such a hulking behemoth; it really should not be being used for this sort of thing (IMO). Every time someone complained about it in the past (including me, FWIW), the answer was that its use was a stopgap, and that once the code was working, the locks would be replaced with lighter-weight code which was not yet written. Well, now it's written, and it has WITNESS, as a side benefit, but the lockmgr() calls are unforntunately still being put in. 8-(. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message