From owner-svn-src-head@freebsd.org Sat Apr 22 02:34:03 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E831ED49CF1; Sat, 22 Apr 2017 02:34:03 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from st13p97im-ztdg18291001.me.com (st13p97im-ztdg18291001.me.com [17.41.193.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BDE428B6; Sat, 22 Apr 2017 02:34:03 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from process-dkim-sign-daemon.st13p97im-ztdg18291001.me.com by st13p97im-ztdg18291001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OOS00L00HSA6P00@st13p97im-ztdg18291001.me.com>; Sat, 22 Apr 2017 02:33:57 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=4d515a; t=1492828437; bh=ma39r/1DDrkFNp97kb3uiwHoMS3Q8ly41myM2FeGoBQ=; h=Date:From:Subject:To:Message-id:MIME-version:Content-type; b=pw87NrXvmhOIGK4l+zOcwuC9ePAdqKCe9Br00Qol4ltcBK3VWKS1efdlz08Mfzk9C 1aP4Z5Ay+oiwUG27Z3m8vg9ir8wF+RcdgFBb1fDh8Twp80bRMG6hABvjKKcKTgaetD 19t2QkegYxmv0zfRPS2jpOI1kugJnC8fR+2ptKxPdkAh4vjRNN390ZxJPGwCRjeErq 9mOg5UBvrFizMksrdFpllT0hbO+DhXVuDUR8O6qblG6jedEUbTUgamOKZzz3sLfmbJ hG28QVUeKlb33BVNYsIxSjPsB39iZNLyah5LgdUORnNc1mT0Y2xQGyE2rV4zL/CdQE b4QkR2eJfQf9w== Received: from icloud.com ([127.0.0.1]) by st13p97im-ztdg18291001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OOS00L00HSK9I00@st13p97im-ztdg18291001.me.com>; Sat, 22 Apr 2017 02:33:56 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-21_20:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1701120000 definitions=main-1704220034 Received: from icloud.com ([127.0.0.1]) by st13p97im-ztdg18291001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OOS00HC7HS2HI20@st13p97im-ztdg18291001.me.com>; Sat, 22 Apr 2017 02:33:56 +0000 (GMT) Date: Fri, 21 Apr 2017 19:33:38 -0700 From: Rui Paulo Subject: Re: svn commit: r317277 - head/sys/crypto/chacha20 In-reply-to: <201704220106.v3M16NLH097822@repo.freebsd.org> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: MIME-version: 1.0 (Mac OS X Mail 10.3 \(3273\)) X-Mailer: Apple Mail (2.3273) Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable References: <201704220106.v3M16NLH097822@repo.freebsd.org> X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2017 02:34:04 -0000 On Apr 21, 2017, at 18:06, Dag-Erling Sm=C3=B8rgrav = wrote: >=20 > Author: des > Date: Sat Apr 22 01:06:23 2017 > New Revision: 317277 > URL: https://svnweb.freebsd.org/changeset/base/317277 >=20 > Log: > Fix counter increment in Salsa and ChaCha. >=20 > In my eagerness to eliminate a branch which is taken once per 2^38 > bytes of keystream, I forgot that the state words are in host order. > Thus, the counter increment code worked fine on little-endian > machines, but not on big-endian ones. Switch to a simpler = (branchful) > solution. I=E2=80=99m surprised there=E2=80=99s no mention of who reviewed your = change, especially when you=E2=80=99re changing crypto code.=