From owner-svn-src-head@freebsd.org Sat Dec 5 03:22:39 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E4B6E4B3944; Sat, 5 Dec 2020 03:22:39 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cnvyl60Qmz4fDH; Sat, 5 Dec 2020 03:22:39 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id BEE492123E; Sat, 5 Dec 2020 03:22:39 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-lf1-f43.google.com with SMTP id s30so10422205lfc.4; Fri, 04 Dec 2020 19:22:39 -0800 (PST) X-Gm-Message-State: AOAM533nMBiiXTyMxIjGIBvWLt1dCugAUcKkmL/owaHX+RFJSyYsJPBD KOrZ8yc3pP6SDuV9p18zttka2NjXpFV1vbDIZio= X-Google-Smtp-Source: ABdhPJyngDalJ+Cu4BLS/I7FeWLWkMNZ3mFL4yk8msKW/2RuozhN9694beg9H35KrcDBNJi3unOAplmDbWTGv/8sHQQ= X-Received: by 2002:a19:e8a:: with SMTP id 132mr1410759lfo.108.1607138558273; Fri, 04 Dec 2020 19:22:38 -0800 (PST) MIME-Version: 1.0 References: <202011291938.0ATJc4Z3081193@repo.freebsd.org> <20201130102758.c600f147a801933bb66529c7@bidouilliste.com> <01F4B070-2CBE-4662-ACDC-20F5E87B751A@lists.zabbadoz.net> <-0GA0tF-2zZxdb99WE9WoUnv9YVf9efjJnMin4IL0bctNp-Bab2Qw2RbUuZTa6y9hP7r0UEUUXGkRSz-OF4k5yR5YmUgU-JJxNWcl48tVSQ=@protonmail.com> <6C2E5C72-BBB7-42D1-9615-07EC536F07ED@lists.zabbadoz.net> In-Reply-To: <6C2E5C72-BBB7-42D1-9615-07EC536F07ED@lists.zabbadoz.net> From: Matthew Macy Date: Fri, 4 Dec 2020 19:22:26 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368163 - in head: sbin/ifconfig sys/dev/if_wg sys/dev/if_wg/include sys/dev/if_wg/include/crypto sys/dev/if_wg/include/sys sys/dev/if_wg/include/zinc sys/dev/if_wg/module sys/dev/if_wg... To: "Bjoern A. Zeeb" Cc: cglogic , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2020 03:22:40 -0000 I worry about the incredible mess of header dependencies that the linuxkpi is prone to introducing. I=E2=80=99m happy to review any proposed changes t= o that effect, but do not feel like it=E2=80=99s important enough to make a priori= ty. Thanks. -M On Mon, Nov 30, 2020 at 08:33 Bjoern A. Zeeb wrote: > On 30 Nov 2020, at 14:53, cglogic wrote: > > > So you propose to make it dependent on linuxkpi? What have to do a > > user who does not compile linuxkpi, but wants to use if_wg? > > If we=E2=80=99d move the implementations into linuxkpi you=E2=80=99d have= to compile > it to use if_wg. > So that this however is only a question. > > Effectively you are using parts of linuxkpi now already, just > copy&pasted (duplicated) into local files under if_wg; for as much as I > can see for most of that would however not require linuxkpi to be > loaded, just present at compile time like any other kernel headers. > > /bz >