From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Sep 26 18:40:07 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76C031065672 for ; Sat, 26 Sep 2009 18:40:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 54E958FC0C for ; Sat, 26 Sep 2009 18:40:07 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8QIe7n3079684 for ; Sat, 26 Sep 2009 18:40:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8QIe72b079683; Sat, 26 Sep 2009 18:40:07 GMT (envelope-from gnats) Resent-Date: Sat, 26 Sep 2009 18:40:07 GMT Resent-Message-Id: <200909261840.n8QIe72b079683@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Zane C.B." Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 536751065695 for ; Sat, 26 Sep 2009 18:33:48 +0000 (UTC) (envelope-from vvelox@vvelox.net) Received: from vulpes.vvelox.net (vulpes.vvelox.net [99.69.115.42]) by mx1.freebsd.org (Postfix) with ESMTP id DAE018FC23 for ; Sat, 26 Sep 2009 18:33:47 +0000 (UTC) Received: from vixen42.vulpes (unknown [192.168.14.1]) (Authenticated sender: vvelox) by vulpes.vvelox.net (Postfix) with ESMTP id 5B231B822 for ; Sat, 26 Sep 2009 00:55:25 -0500 (CDT) Message-Id: <1253944390.66752@vixen42.vulpes> Date: Sat, 26 Sep 2009 00:53:10 -0500 From: "Zane C.B." To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.4.9 Cc: Subject: ports/139160: update port: devel/dbus This fixes dbus on systems using nss_ldap for users that are members of more than 16 groups. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2009 18:40:07 -0000 >Number: 139160 >Category: ports >Synopsis: update port: devel/dbus This fixes dbus on systems using nss_ldap for users that are members of more than 16 groups. >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Sep 26 18:40:06 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Zane C.B. >Release: FreeBSD 7.2-STABLE i386 >Organization: >Environment: System: FreeBSD 7.2-STABLE #2: Tue Sep 22 17:59:50 CDT 2009 root@vixen42.vulpes:/usr/obj/usr/src/sys/GENERIC >Description: This bug is related entirely to either a bug in nss_ldap or some of the group stuff in the base system. I am not sure which. This patch provides a work around for systems using nss_ldap on systems with a non-standard, greater than 16, value for NGROUPS_MAX. >How-To-Repeat: 1: Find a system using "net/nss_ldap". 2: Recompile the kernel with a larger NGROUP_MAX value. 3: Add a user in LDAP to more than 17 groups via LDAP. 4: Run "dbus-laucnh" and watch it error with a message about not being able to get user info. 5: Apply the patch to "devel/dbus/files/patch-dbus_dbus-sysdeps-unix.c". 6: Recompile "devel/dbus". 7: Reinstall "devel/dbus". 8: Rerun the test and watch it work. >Fix: --- devel_dbus_Makefile.diff begins here --- --- Makefile.orig 2009-09-26 00:42:11.000000000 -0500 +++ Makefile 2009-09-26 00:42:18.000000000 -0500 @@ -7,7 +7,7 @@ PORTNAME= dbus PORTVERSION?= 1.2.4.6 -PORTREVISION?= 1 +PORTREVISION?= 2 CATEGORIES= devel gnome MASTER_SITES= http://dbus.freedesktop.org/releases/dbus/ DISTNAME= dbus-${PORTVERSION}permissive --- devel_dbus_Makefile.diff ends here --- --- devel_dbus_files_patch-dbus_dbus-sysdeps-unix.c.diff begins here --- --- files/orig.patch-dbus_dbus-sysdeps-unix.c 2009-09-26 00:33:25.000000000 -0500 +++ files/patch-dbus_dbus-sysdeps-unix.c 2009-09-26 00:37:18.000000000 -0500 @@ -1,6 +1,14 @@ ---- dbus/dbus-sysdeps-unix.c.orig 2008-08-06 13:00:29.000000000 -0400 -+++ dbus/dbus-sysdeps-unix.c 2008-08-10 15:04:32.000000000 -0400 -@@ -1041,9 +1041,9 @@ write_credentials_byte (int +--- dbus/dbus-sysdeps-unix.c.old 2009-09-26 00:35:27.000000000 -0500 ++++ dbus/dbus-sysdeps-unix.c 2009-09-26 00:37:08.000000000 -0500 +@@ -54,6 +54,7 @@ + #include + #include + #include ++#include + + #ifdef HAVE_ERRNO_H + #include +@@ -1041,9 +1042,9 @@ int bytes_written; char buf[1] = { '\0' }; #if defined(HAVE_CMSGCRED) @@ -12,7 +20,7 @@ } cmsg; struct iovec iov; struct msghdr msg; -@@ -1054,10 +1054,10 @@ write_credentials_byte (int +@@ -1054,10 +1055,10 @@ msg.msg_iov = &iov; msg.msg_iovlen = 1; @@ -26,7 +34,7 @@ cmsg.hdr.cmsg_level = SOL_SOCKET; cmsg.hdr.cmsg_type = SCM_CREDS; #endif -@@ -1133,9 +1133,9 @@ _dbus_read_credentials_socket (int +@@ -1133,9 +1134,9 @@ pid_read = DBUS_PID_UNSET; #ifdef HAVE_CMSGCRED @@ -38,7 +46,7 @@ } cmsg; #elif defined(LOCAL_CREDS) -@@ -1172,8 +1172,8 @@ _dbus_read_credentials_socket (int +@@ -1172,8 +1173,8 @@ #if defined(HAVE_CMSGCRED) || defined(LOCAL_CREDS) memset (&cmsg, 0, sizeof (cmsg)); @@ -49,7 +57,7 @@ #endif again: -@@ -1211,7 +1211,8 @@ _dbus_read_credentials_socket (int +@@ -1211,7 +1212,8 @@ } #if defined(HAVE_CMSGCRED) || defined(LOCAL_CREDS) @@ -59,7 +67,7 @@ { dbus_set_error (error, DBUS_ERROR_FAILED, "Message from recvmsg() was not SCM_CREDS"); -@@ -1238,8 +1239,11 @@ _dbus_read_credentials_socket (int +@@ -1238,8 +1240,11 @@ cr_len, (int) sizeof (cr), _dbus_strerror (errno)); } #elif defined(HAVE_CMSGCRED) @@ -73,3 +81,12 @@ #elif defined(LOCAL_CREDS) pid_read = DBUS_PID_UNSET; uid_read = cmsg.cred.sc_uid; +@@ -1592,7 +1597,7 @@ + int buf_count; + int i; + +- buf_count = 17; ++ buf_count = NGROUPS_MAX + 1; + buf = dbus_new (gid_t, buf_count); + if (buf == NULL) + { --- devel_dbus_files_patch-dbus_dbus-sysdeps-unix.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: