Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 May 2006 18:16:40 +0200
From:      Erwin Lansing <erwin@FreeBSD.org>
To:        Jean-Yves Lefort <jylefort@FreeBSD.org>
Cc:        vd@FreeBSD.org, edwin@mavetju.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/devel Makefile ports/devel/glib20 Makefile ports/devel/glib20-reference Makefile bsd.gnome-reference.mk
Message-ID:  <20060510161640.GA83847@droso.net>
In-Reply-To: <20060510175642.3b726acc.jylefort@FreeBSD.org>
References:  <200605092203.k49M3Rqk027415@repoman.freebsd.org> <20060509232419.GB1117@k7.mavetju> <20060510013356.ebb65c03.jylefort@FreeBSD.org> <20060509234346.GD1117@k7.mavetju> <20060510015054.2b3e900d.jylefort@FreeBSD.org> <20060510052227.GA90330@qlovarnika.bg.datamax> <20060510175642.3b726acc.jylefort@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--bg08WKrSYDhXBjb5
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 10, 2006 at 05:56:42PM +0200, Jean-Yves Lefort wrote:
> On Wed, 10 May 2006 08:22:27 +0300
> Vasil Dimov <vd@FreeBSD.org> wrote:
>=20
> > On Wed, May 10, 2006 at 01:50:54AM +0200, Jean-Yves Lefort wrote:
> > > On Wed, 10 May 2006 09:43:46 +1000
> > > Edwin Groothuis <edwin@mavetju.org> wrote:
> > >=20
> > > > On Wed, May 10, 2006 at 01:33:56AM +0200, Jean-Yves Lefort wrote:
> > > > > On Wed, 10 May 2006 09:24:19 +1000
> > > > > Edwin Groothuis <edwin@mavetju.org> wrote:
> > > > >=20
> > > > > > On Tue, May 09, 2006 at 10:03:27PM +0000, Jean-Yves Lefort wrot=
e:
> > > > > > > jylefort    2006-05-09 22:03:27 UTC
> > > > > > >=20
> > > > > > >   FreeBSD ports repository
> > > > > > >=20
> > > > > > >   Modified files:
> > > > > > >     devel                Makefile=20
> > > > > > >     devel/glib20         Makefile=20
> > > > > > >   Added files:
> > > > > > >     devel/glib20-reference Makefile bsd.gnome-reference.mk=20
> > > > > > >   Log:
> > > > > > >   Add glib20-reference and the bsd.gnome-reference.mk framewo=
rk.
> > > > > > >  =20
> > > > > > >   Revision  Changes    Path
> > > > > > >   1.2197    +1 -0      ports/devel/Makefile
> > > > > > >   1.1       +16 -0     ports/devel/glib20-reference/Makefile =
(new)
> > > > > > >   1.1       +53 -0     ports/devel/glib20-reference/bsd.gnome=
-reference.mk (new)
> > > > > > >   1.122     +5 -0      ports/devel/glib20/Makefile
> > > > > >=20
> > > > > > Where are the manditory comment lines in this makefile?
> > > > >=20
> > > > > In bsd.gnome-reference.mk.
> > > >=20
> > > > I mean the :
> > > >=20
> > > > # New ports collection makefile for:   gtk20-apireference
> > > > # Date created:        13 June 2001
> > > > # Whom:                Edwin Groothuis (edwin@mavetju.org)
> > > > #
> > > > # $FreeBSD: ports/x11-toolkits/gtk20-apireference/Makefile,v 1.9 20=
04/12/15 04:34:53 edwin Exp $
> > > > #
> > >=20
> > > Omitted, since it's useless (and not mandatory btw).
> > >=20
> > It's not useless since it's nice to see who and when created that file
>=20
> That information is available from the CVS repository:
>=20
> http://www.freebsd.org/cgi/cvsweb.cgi/glib20-reference/
>=20
> > How do you define mandatory?
>=20
> Written in imperative form in some document such as the Porter's
> Handbook.
>=20
> > From the 14599 Makefiles in the ports collection there is just one
> > which do not have those lines: ports/sysutils/bacula-client/Makefile,
> > yours (devel/glib20-reference/Makefile) is the second one.
> >=20
> > Don't think that I trying to tell you what to do, its just my wish to
> > see those lines there.
>=20
> My own wish is to get rid of that religious ritual (which is btw
> inconsistent, since various levels of tabulation and various date
> formats are used).
>=20

Whether official or unofficial, this has been a policy since the start.
I am not going to info a discussion about if we want to keep that or
not, which doesn't below on these list, but I am objection to your
self-justice by changing existing tradition without prior discussion.
Please add the header to the Makefile and start a discussion on the
right mailinglist.

-erwin

--=20
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin@FreeBSD.org
And it makes you cry.            <____) (____>    erwin@aauug.dk

--bg08WKrSYDhXBjb5
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)

iD8DBQFEYhHoqy9aWxUlaZARAqLcAJ48w2uHLs2Di7TYVTw1rQuiVWcK6gCeNRpy
xvDilmrGZrbyhpRbFZsI82k=
=d1wc
-----END PGP SIGNATURE-----

--bg08WKrSYDhXBjb5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060510161640.GA83847>