From owner-svn-src-head@freebsd.org Fri Dec 11 23:54:38 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 161489D769D for ; Fri, 11 Dec 2015 23:54:38 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4887196D for ; Fri, 11 Dec 2015 23:54:37 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x232.google.com with SMTP id c17so29413745wmd.1 for ; Fri, 11 Dec 2015 15:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=S/KkB90Bz68DgWsxapReY2KvtkSogKCuvbbqLBw6IDM=; b=fnQCZ1ApHB56dNwWOOyTB7JFzT7eCfiqKXLw6ho92LfJZxGrz+A0SD6Yx/8FxVDN4E fjvPoCWbGOjrhXvvq8WDV7LzOZezRbbos0x9c4B8DGc2gOhqNeNqnlSfwlUsnVfH+mvR 3H9esPHZjZSXn+ceyGDEnt/orhZGlD6MQbz6QKHXhK4sMyOaPcQc4CqFzxRjS+eHqDgf mJ0iwnBZQSuTAYF3W+wA+UYxxi3/1ih8xV74UWVu2A8i1fs3R8NRsZL6Tu1wmDI30G5Q N4lSEbTOSN9ZRllFPalwPbNZxSyXAcGzD4yCxpzNmjfKanfIF9dWOv7NlkcRZnA7/o0L +sjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=S/KkB90Bz68DgWsxapReY2KvtkSogKCuvbbqLBw6IDM=; b=LgosSoRMGGHTvAOtp/LaIP2/Sqk3U3j6ZY0SsCOQ+IqBjCOkiLq5lkp+Wp1D7wFrnC ghnvxQrVKdKZZGLtB3whJNgVhEnINByozuYErTZVEci5SN1eyf5yBTg7GCI/ybTLSeJd gV5OMa+Qd+qLt9jEhunEvKyoPKmyQMUgIdbCr30jxxsuaCEMqGkA30yaABpe2B0Rzfaf J/D/bdqyVllHMcCtJtrylnEnVsoq3hRTnyRoJZdcjf43haNuENj/HN57QK9bRcOYf7+e dCKXj7IkfFS7GUMloAO/pnTD2xoRXriq+5tQToAsb1CSQSdm9lgHmtNkNVAUh6w4gjgw 1Lqw== X-Gm-Message-State: ALoCoQnc5gVGQaZj1TPpyunIJJ2ideaSazbu7eFEBiU24tCSKkV4nS8N4xxVUKiSaDxaJEChiC9tqwBpFtRwsdjzTLa/nLCJNylN8eUT0sGARz145Cp8xgs= MIME-Version: 1.0 X-Received: by 10.194.223.39 with SMTP id qr7mr22165566wjc.63.1449878075307; Fri, 11 Dec 2015 15:54:35 -0800 (PST) Received: by 10.194.85.167 with HTTP; Fri, 11 Dec 2015 15:54:35 -0800 (PST) In-Reply-To: <20151211132437.GH82577@kib.kiev.ua> References: <201511230709.tAN79Z4L062228@repo.freebsd.org> <20151210213324.GF82577@kib.kiev.ua> <20151211132437.GH82577@kib.kiev.ua> Date: Sat, 12 Dec 2015 00:54:35 +0100 Message-ID: Subject: Re: svn commit: r291171 - in head/sys: amd64/amd64 compat/ia32 i386/i386 kern sys From: Oliver Pinter To: Konstantin Belousov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2015 23:54:38 -0000 On Friday, December 11, 2015, Konstantin Belousov wrote: > On Thu, Dec 10, 2015 at 10:48:11PM +0100, Oliver Pinter wrote: > > On Thursday, December 10, 2015, Konstantin Belousov > > > wrote: > > > > > On Thu, Dec 10, 2015 at 10:18:19PM +0100, Oliver Pinter wrote: > > > > On Mon, Nov 23, 2015 at 8:09 AM, Konstantin Belousov < > kib@freebsd.org > > > > wrote: > > > > > Author: kib > > > > > Date: Mon Nov 23 07:09:35 2015 > > > > > New Revision: 291171 > > > > > URL: https://svnweb.freebsd.org/changeset/base/291171 > > > > > > > > > > Log: > > > > > Split kerne timekeep ABI structure vdso_sv_tk out of the struct > > > > > sysentvec. This allows the timekeep data to be shared between > > > similar > > > > > ABIs which cannot share sysentvec. > > > > > > > > > > Make the timekeep_push_vdso() tick callback to the timekeep > > > structures > > > > > instead of sysentvecs. If several sysentvec share the vdso_sv_tk > > > > > structure, we would update the userspace data several times on > each > > > > > tick, without the change. > > > > > > > > > > Only allocate vdso_sv_tk in the exec_sysvec_init() sysinit when > > > > > sysentvec is marked with the new SV_TIMEKEEP flag. This saves > > > > > allocation and update of unneeded vdso_sv_tk for ABIs which do > not > > > > > provide userspace gettimeofday yet, which are PowerPCs arches > right > > > > > now. > > > > > > > > > > Make vdso_sv_tk allocator public, namely split out and export > > > > > alloc_sv_tk() and alloc_sv_tk_compat32(). ABIs which share > timekeep > > > > > data now can allocate it manually and share as appropriate. > > > > > > > > > > Requested by: nwhitehorn > > > > > Tested by: nwhitehorn, pho > > > > > Sponsored by: The FreeBSD Foundation > > > > > MFC after: 2 weeks > > > > > > > > Hello Konstantin! > > > > > > > > Do you plan to MFC back this changes to 10-STABLE in these days? > > > > > > I decided to not merge the change. > > > > > > > And if I'm not wrong, the rationale behind this decision is the type > > stability of struct sysvec / sysent. > You are wrong. The modules which use sysentvec are marked as > DECLARE_MODULE_TIED(), to designate them as requiring kernel of exactly > same version due to KBI issues. I.e. the merge would indeed break KBI, > but KBI breakage there is expected and considered acceptable on the > stable branch. Mainly, the affected modules are ABI emulators (linux.ko > and similar). > > I got demotivated to merge a prerequisite changes which modified code > in kern_sharedpage.c, and do not want to obliterate the code and > history on stable/10 with 'fake' merge. This makes the revision you > asked about non-mergeable. > Okay, thank you for the detailed answer. If