From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar 22 20:10:55 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 070F416A4CE
	for <freebsd-hackers@freebsd.org>;
	Tue, 22 Mar 2005 20:10:55 +0000 (GMT)
Received: from mgw-x3.nokia.com (mgw-x3.nokia.com [131.228.20.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 968FD43D2F
	for <freebsd-hackers@freebsd.org>;
	Tue, 22 Mar 2005 20:10:53 +0000 (GMT)
	(envelope-from Vijay.Singh@nokia.com)
Received: from esdks002.ntc.nokia.com (esdks002.ntc.nokia.com
	[172.21.138.121])j2MKAkE29906	for <freebsd-hackers@freebsd.org>;
	Tue, 22 Mar 2005 22:10:49 +0200 (EET)
X-Scanned: Tue, 22 Mar 2005 22:10:31 +0200 Nokia Message Protector V1.3.34
	2004121512 - RELEASE
Received: (from root@localhost)
	by esdks002.ntc.nokia.com (8.12.9/8.12.9) id j2MKAV2V027678
	for <freebsd-hackers@freebsd.org>; Tue, 22 Mar 2005 22:10:31 +0200
Received: from mgw-int1.ntc.nokia.com (172.21.143.96)
	by esdks002.ntc.nokia.com 00Cbls0D; Tue, 22 Mar 2005 22:10:30 EET
Received: from daebh002.NOE.Nokia.com (daebh002.americas.nokia.com
	[10.241.35.122])j2MKA9M20417	for <freebsd-hackers@freebsd.org>;
	Tue, 22 Mar 2005 22:10:09 +0200 (EET)
Received: from mvebe001.NOE.Nokia.com ([172.18.140.37]) by
	daebh002.NOE.Nokia.com with Microsoft SMTPSVC(5.0.2195.6881);
	Tue, 22 Mar 2005 14:08:19 -0600
X-MimeOLE: Produced By Microsoft Exchange V6.0.6603.0
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Mar 2005 12:08:18 -0800
Message-ID: <E40595640FD457418D8F9005C2BEC8496456D4@mvebe001.americas.nokia.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: ip_reass() - possibly incorrect goto
Thread-Index: AcUvGuM4neQU4cxlTtmqRlrToY3eHA==
From: <Vijay.Singh@nokia.com>
To: <freebsd-hackers@freebsd.org>
X-OriginalArrivalTime: 22 Mar 2005 20:08:19.0296 (UTC)
	FILETIME=[E4212600:01C52F1A]
Subject: ip_reass() - possibly incorrect goto
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Mar 2005 20:10:55 -0000

Hi hackers, I am looking at the ip_reass() routine. In case of the 1st =
fragment we create the reassembly queue. After the queue has been =
inserted in the hash bucket, the if () code does a " goto inserted". =
Should this be changed to "goto done" instead? Any code that is executed =
for the 1st fragment, like frag per packet limiting and complete =
reassembly are not valid. Am I mistaken?

br
vijay