From owner-freebsd-ports@FreeBSD.ORG  Wed Aug 10 12:22:00 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0523A106567E
	for <freebsd-ports@FreeBSD.org>; Wed, 10 Aug 2011 12:22:00 +0000 (UTC)
	(envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 24AA58FC20
	for <freebsd-ports@FreeBSD.org>; Wed, 10 Aug 2011 12:21:58 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA20444;
	Wed, 10 Aug 2011 15:21:57 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <4E4277E4.1070008@FreeBSD.org>
Date: Wed, 10 Aug 2011 15:21:56 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:5.0) Gecko/20110705 Thunderbird/5.0
MIME-Version: 1.0
To: timur@FreeBSD.org, freebsd-ports@FreeBSD.org
X-Enigmail-Version: 1.2pre
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: 
Subject: net/samba35 build fails with samba34-libsmbclient installed
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2011 12:22:00 -0000


net/samba35 build fails with samba34-libsmbclient installed.
This happens because of the following lines in source3/Makefile:
LIBNETAPI=bin/libnetapi.a
LIBNETAPI_LIBS= -lnetapi
...
bin/net: $(BINARY_PREREQS) $(NET_OBJ)  $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
$(LIBNETAPI)
        @echo Linking $@
        $(CC) -o $@ $(NET_OBJ) $(DYNEXP) $(LDFLAGS) $(LIBS) \
                $(POPT_LIBS) $(KRB5LIBS) $(UUID_LIBS) $(LDAP_LIBS) \
                $(PASSDB_LIBS) $(TERMLDFLAGS) $(TERMLIBS) $(NSCD_LIBS) \
                $(LIBTALLOC_LIBS) $(LIBTDB_LIBS) $(LIBWBCLIENT_LIBS)
$(LIBNETAPI_LIBS) \
                $(ZLIB_LIBS)

Plus the fact that there is -L/usr/local/lib flag passed to linker.
Because of that the build picks up libnetapi.so installed by samba34-libsmbclient
instead of bin/libnetapi.a compiled by net/samba35 itself.

Couple of potential workarounds:
- substitute LIBNETAPI_LIBS with LIBNETAPI in the linking recipes
- change value of LIBNETAPI_LIBS to be the same as LIBNETAPI

The above can probably be done in Makefile.in or in configure.in, although not sure.

P.S. BTW, so libsmbclient can not be built from samba35 sources?

-- 
Andriy Gapon