From owner-freebsd-net@FreeBSD.ORG Mon Dec 5 19:24:18 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F93B1065670 for ; Mon, 5 Dec 2011 19:24:18 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id A14E88FC17 for ; Mon, 5 Dec 2011 19:24:17 +0000 (UTC) Received: by bkat2 with SMTP id t2so8607065bka.13 for ; Mon, 05 Dec 2011 11:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Tq/Zhxv9IuMz0PDGAgJ1v85xisXO0IE6ZHoLCyYfQo0=; b=KwPEPFcqpNQcqVpeSsyOcQgL/nTPKdAHodrrYHJeXIsGkNgv6oJg9Lb+gyU+Fd4DyE njPW2Tgnc+9rPBR9z7Sp2WIXYdFOpH/gxqVdsw8TB4ATeyKHJzqtl4tO/9kujwnme3tc 8J16Q9f48SYoJb0DAjSZ90ZIck7MyPLdlxyWA= MIME-Version: 1.0 Received: by 10.180.102.162 with SMTP id fp2mr14389693wib.50.1323113056240; Mon, 05 Dec 2011 11:24:16 -0800 (PST) Received: by 10.180.24.1 with HTTP; Mon, 5 Dec 2011 11:24:16 -0800 (PST) In-Reply-To: <4EDCD23C.8050706@freebsd.org> References: <4EDCD23C.8050706@freebsd.org> Date: Mon, 5 Dec 2011 11:24:16 -0800 Message-ID: From: Jack Vogel To: Andre Oppermann Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: FreeBSD Net Subject: Re: VLAN HWTSO question/problem X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2011 19:24:18 -0000 I have solved the problem. Was my bug :) Turns out the xmit path has been wrong for quite some time, it was only putting the VLAN tag and command bit into the last descriptor of a frame, it should have been doing it in ALL of them. Its fixed in my internal code base, and will be coming down the pipe soon. I've now turned HWTSO back on as default as well. Thanks to everyone that replied. Jack On Mon, Dec 5, 2011 at 6:16 AM, Andre Oppermann wrote: > On 02.12.2011 21:06, Jack Vogel wrote: > >> I have just discovered during some validation testing on the em driver, >> that if HWTSO is enabled >> at the same time as VLAN_HWTAGGING and/or VLAN_HWFILTER that its broken. >> >> Looking at the vlan source its not obvious why this would be the case, but >> netperf just fails completely. >> I can turn TAGGING off and I can get TSO, or turn off TSO and get >> TAGGING/FILTERING, but not >> both :( >> >> My tester only has 8.2 to try this on, not sure if its a bug or a design >> limitation, can someone >> enlighten me? At the moment I'm thinking of just turning HWTSO off by >> default? >> > > Maybe the HW or drive chokes on the overall ethernet frame being longer > than 64K due to the VLAN header even though the IP packet part stays > within the limits? > > -- > Andre >