From nobody Sun Jun 20 18:25:48 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BB2F611D8F97 for ; Sun, 20 Jun 2021 18:25:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G7Lgw3L7kz4ZXY for ; Sun, 20 Jun 2021 18:25:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 59DAB6A0B for ; Sun, 20 Jun 2021 18:25:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15KIPmK0025158 for ; Sun, 20 Jun 2021 18:25:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15KIPmcC025157 for ports-bugs@FreeBSD.org; Sun, 20 Jun 2021 18:25:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256736] [bsd.port.mk] [regression] [patch] _FLAVOR_RECURSIVE_SH passes flavor to child make Date: Sun, 20 Jun 2021 18:25:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ross@ross-williams.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: otis@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256736 Bug ID: 256736 Summary: [bsd.port.mk] [regression] [patch] _FLAVOR_RECURSIVE_SH passes flavor to child make Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: otis@FreeBSD.org Reporter: ross@ross-williams.net Assignee: otis@FreeBSD.org Flags: maintainer-feedback?(otis@FreeBSD.org) Created attachment 225957 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225957&action= =3Dedit Patch The change introduced in bug #256301 (review D30579), which prevents child = make processes from receiving an empty `FLAVOR` variable when `FLAVOR` should be unset has the side effect of allowing any `FLAVOR` already in the parent ma= ke process environment to propagate to the child. The attached patch unsets `FLAVOR` before starting the child make. Behavior before: ``` $ make FLAVOR=3Dzabbix54 ... =3D=3D=3D> zabbix54-agent-5.4.1 FLAVOR is defined (to zabbix54) while = this port does not have FLAVORS. *** Error code 1 Stop. make[1]: stopped in /usr/ports/net-mgmt/zabbix54-agent *** Error code 1 Stop. ``` Expected behavior after: ``` $ make FLAVOR=3Dzabbix54 ... =3D=3D=3D> Fetching all distfiles required by zabbix54-agent-5.4.1 for = building $ echo $? 0 ``` --=20 You are receiving this mail because: You are the assignee for the bug.=