Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Mar 2012 19:45:27 GMT
From:      Jason Helfman <jgh@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/166057: comms/umcs7840: remove unknown post-deinstall target
Message-ID:  <201203131945.q2DJjRK4049884@freefall.freebsd.org>
Resent-Message-ID: <201203131950.q2DJo1Q4050524@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         166057
>Category:       ports
>Synopsis:       comms/umcs7840: remove unknown post-deinstall target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 13 19:50:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 8.2-STABLE FreeBSD 8.2-STABLE #5 r227907: Wed Nov 23 21:55:50 UTC 2011 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


	
>Description:
there is an unknown target in the Makefile that will never be called.

>How-To-Repeat:
	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/comms/umcs7840/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	16 Jul 2011 20:11:48 -0000	1.4
+++ Makefile	13 Mar 2012 19:43:48 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	umcs7840
 PORTVERSION=	${MAINVERSION}.${VERSIONDATE}
+PORTREVISION=	1
 CATEGORIES=	comms kld
 MASTER_SITES=	http://lev.serebryakov.spb.ru/download/umcs7840/
 PKGNAMESUFFIX=	-kmod
@@ -23,6 +24,8 @@
 
 KMODDIR?=	/boot/modules
 PLIST_SUB+=	KMODDIR=${KMODDIR}
+SUB_LIST=	KMODDIR=${KMODDIR}
+SUB_FILES=	pkg-deinstall
 MAKE_ENV+=	KMODDIR=${KMODDIR}
 
 MANCOMPRESSED=	yes
@@ -39,7 +42,4 @@
 post-install:
 	kldxref ${KMODDIR}
 
-post-deinstall:
-	kldxref ${KMODDIR}
-
 .include <bsd.port.post.mk>
Index: files/pkg-deinstall.in
===================================================================
RCS file: files/pkg-deinstall.in
diff -N files/pkg-deinstall.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/pkg-deinstall.in	13 Mar 2012 19:43:48 -0000
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "$2" = "DEINSTALL" ]; then
+  /usr/sbin/kldxref %%KMODDIR%%
+fi
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203131945.q2DJjRK4049884>