From owner-svn-src-head@freebsd.org Sat Apr 22 02:42:07 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66A14D49209 for ; Sat, 22 Apr 2017 02:42:07 +0000 (UTC) (envelope-from 0100015b9386dee4-dad811f0-0615-4160-85d2-b9b7709a15a0-000000@amazonses.com) Received: from a8-56.smtp-out.amazonses.com (a8-56.smtp-out.amazonses.com [54.240.8.56]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 29A09E8E for ; Sat, 22 Apr 2017 02:42:06 +0000 (UTC) (envelope-from 0100015b9386dee4-dad811f0-0615-4160-85d2-b9b7709a15a0-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn; d=tarsnap.com; t=1492828741; h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=Nh3gLOq5f2id/40/aafYhVBtMU/HVgkhDyhDNaQs1yo=; b=oFmVLuaZH1K42Vq84r7tub2Aga5YnK2ZH9/WUMr8MqYAOdSQClIyGKYEcrUA1cSE 95IzJakyvw+7vuOQAVE5Jd36jzKB7eFlad/2k2JzH4BUp/U+wPNmH+/epZCVdK6X4XM HoyfVkB2IovhAaJB9xxl/S864OB83rL3a5U0QBVE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1492828741; h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=Nh3gLOq5f2id/40/aafYhVBtMU/HVgkhDyhDNaQs1yo=; b=Mjou+S4hgweTHS9H1xfE/OLYQNqQpOM/RTzJCv75OEzlTDXi2uCg0Q53vrW6F/yV t7o8XeMGRhNji/ZvZTyF6HPHua62LY6VGiYr+L8eYhDI/dfujmUDVoGKsJaaNpcQopw XLJI8VPQTUIFNHKWz4VnvA1gpziyZzL2V81NGz2A= Subject: Re: svn commit: r317277 - head/sys/crypto/chacha20 To: Rui Paulo , =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= References: <201704220106.v3M16NLH097822@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Colin Percival Message-ID: <0100015b9386dee4-dad811f0-0615-4160-85d2-b9b7709a15a0-000000@email.amazonses.com> Date: Sat, 22 Apr 2017 02:39:01 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SES-Outgoing: 2017.04.22-54.240.8.56 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2017 02:42:07 -0000 On 04/21/17 19:33, Rui Paulo wrote: > On Apr 21, 2017, at 18:06, Dag-Erling Smørgrav wrote: >> Author: des >> Date: Sat Apr 22 01:06:23 2017 >> New Revision: 317277 >> URL: https://svnweb.freebsd.org/changeset/base/317277 >> >> Log: >> Fix counter increment in Salsa and ChaCha. >> >> In my eagerness to eliminate a branch which is taken once per 2^38 >> bytes of keystream, I forgot that the state words are in host order. >> Thus, the counter increment code worked fine on little-endian >> machines, but not on big-endian ones. Switch to a simpler (branchful) >> solution. > > I’m surprised there’s no mention of who reviewed your change, especially when you’re changing crypto code. Reviewed by: cperciva -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid