Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Mar 2009 10:43:12 -0300
From:      "Carlos A. M. dos Santos" <unixmania@gmail.com>
To:        Juli Mallett <jmallett@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r190458 - head/sys/dev/wpi
Message-ID:  <e71790db0903290643w3d044b78na9b015fac556f26d@mail.gmail.com>
In-Reply-To: <200903270317.n2R3HPR6046525@svn.freebsd.org>
References:  <200903270317.n2R3HPR6046525@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 27, 2009 at 12:17 AM, Juli Mallett <jmallett@freebsd.org> wrote:
> Author: jmallett
> Date: Fri Mar 27 03:17:25 2009
> New Revision: 190458
> URL: http://svn.freebsd.org/changeset/base/190458
>
> Log:
>  o) Check that no overrun or CRC errors were encountered in receiving a
>     packet.  Linux, OpenBSD and our iwn(4) all do this.  It also results in
>     a huge performance improvement (and the rejection of a fair number of
>     apparently-bad packets on receive) on my hardware.
>  o) Like the wpi(4) driver in OpenBSD, and like our iwn(4), also drop runt
>     packets.
>  o) Don't bother doing IFQ_POLL and then IFQ_DRV_DEQUEUE, just do
>     IFQ_DRV_DEQUEUE outright.  This is more similar to how OpenBSD and our
>     iwn(4) work.

Do you plan to MFC this?

-- 
My preferred quotation of Robert Louis Stevenson is "You cannot
make an omelette without breaking eggs". Not because I like the
omelettes, but because I like the sound of eggs being broken.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e71790db0903290643w3d044b78na9b015fac556f26d>