Date: Thu, 13 May 2010 07:00:17 GMT From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-fs@FreeBSD.org Subject: Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14 Message-ID: <201005130700.o4D70HWQ075033@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/144214; it has been noted by GNATS. From: Andriy Gapon <avg@icyb.net.ua> To: bug-followup@FreeBSD.org, c.kworr@gmail.com Cc: Robert Noland <rnoland@FreeBSD.org> Subject: Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14 Date: Thu, 13 May 2010 09:59:00 +0300 This is a multi-part message in MIME format. --------------010603020208000201000600 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit It seems that I have been misunderstanding the problem. "ZFS: gang block detected" won't even appear if boot code is too old. Having briefly glanced over the code and comparing it to the code in osol and in zio_gang_tree_issue(), I think the following change is needed. But I am not sure if it is a real fix for the issue at hand. If anyone can reproduce the problem, could you please test this change? Thanks! -- Andriy Gapon --------------010603020208000201000600 Content-Type: text/plain; name="zfs-boot-gang.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="zfs-boot-gang.patch" ZGlmZiAtLWdpdCBhL3N5cy9ib290L3pmcy96ZnNpbXBsLmMgYi9zeXMvYm9vdC96ZnMvemZz aW1wbC5jCmluZGV4IGRjMjllMGUuLmVhZTAwMjMgMTAwNjQ0Ci0tLSBhL3N5cy9ib290L3pm cy96ZnNpbXBsLmMKKysrIGIvc3lzL2Jvb3QvemZzL3pmc2ltcGwuYwpAQCAtOTYyLDggKzk2 MiwxMyBAQCB6aW9fcmVhZF9nYW5nKHNwYV90ICpzcGEsIGNvbnN0IGJsa3B0cl90ICpicCwg Y29uc3QgZHZhX3QgKmR2YSwgdm9pZCAqYnVmKQogCQlyZXR1cm4gKEVJTyk7CiAKIAlmb3Ig KGkgPSAwOyBpIDwgU1BBX0dCSF9OQkxLUFRSUzsgaSsrKSB7Ci0JCWlmICh6aW9fcmVhZChz cGEsICZ6aW9fZ2IuemdfYmxrcHRyW2ldLCBidWYpKQorCQlibGtwdHJfdCAqZ2JwID0gJnpp b19nYi56Z19ibGtwdHJbaV07CisKKwkJaWYgKEJQX0lTX0hPTEUoZ2JwKSkKKwkJCWNvbnRp bnVlOworCQlpZiAoemlvX3JlYWQoc3BhLCBnYnAsIGJ1ZikpCiAJCQlyZXR1cm4gKEVJTyk7 CisJCWJ1ZiA9IChjaGFyKilidWYgKyBCUF9HRVRfUFNJWkUoZ2JwKTsKIAl9CiAgCiAJcmV0 dXJuICgwKTsK --------------010603020208000201000600--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005130700.o4D70HWQ075033>