From owner-freebsd-bugs@FreeBSD.ORG  Mon Dec 29 06:00:13 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 028641065676
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 29 Dec 2008 06:00:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E98128FC1F
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 29 Dec 2008 06:00:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBT606Q5045030
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 29 Dec 2008 06:00:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBT606Ip045029;
	Mon, 29 Dec 2008 06:00:06 GMT (envelope-from gnats)
Date: Mon, 29 Dec 2008 06:00:06 GMT
Message-Id: <200812290600.mBT606Ip045029@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dieter <freebsd@sopwith.solgatos.com>
Cc: 
Subject: Re: kern/118093: firewire bus reset hogs CPU,
	causing data to be lost 
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Dieter <freebsd@sopwith.solgatos.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Dec 2008 06:00:13 -0000

The following reply was made to PR kern/118093; it has been noted by GNATS.

From: Dieter <freebsd@sopwith.solgatos.com>
To: freebsd-firewire@freebsd.org, bug-followup@freebsd.org
Cc:  
Subject: Re: kern/118093: firewire bus reset hogs CPU, causing data to be lost 
Date: Sun, 28 Dec 2008 21:49:00 +0000

 > >>> I confirmed that spl's are complete no-ops since rel 5.  So, you want 
 > >>> to ignore
 > >>> them as they are just markers now where locking should be implemented.
 > >>>       
 > >
 > > I hunted down the spl code, and you're right.  Wow, I wonder how drivers
 > > still using spl calls work at all?
 > >
 > >   
 > I believe that the spl() calls are just left there as a hint where 
 > locking should be.
 > 
 > As far as I understand, we need to pay attention to the mutex locks.
 
 I'll rephrase my question.  In the old days, locking was done with spl.
 The new way is with mutex.  But with the spl calls being replaced with
 noops, and as far as I can tell the driver is not using mutex, there
 doesn't appear to be any locking.  So the driver can step on itself.
 
 
 > >> is to real behavior, but /var/log/messages has a tendency to get garbled 
 > >> like this:
 > >>
 > >> Dec 22 16:00:18 home-test kernel: fwohci1: Initiate bus reset
 > >> Dec 22 16:00:18 home-test kernel: fwohci1: BUS reset
 > >> Dec 22 16:00:18 home-test kernel: fwohci1: node_id=0xc800ffc0, gen=8, 
 > >> CYCLEMASTER mode
 > >> Dec 22 16:00:18 home-test kernel: firewi
 > >> Dec 22 16:00:18 home-test kernel: re1:
 > >> Dec 22 16:00:18 home-test kernel: 1 n
 > >> Dec 22 16:00:18 home-test kernel: odes
 > >> Dec 22 16:00:18 home-test kernel: , ma
 > >> Dec 22 16:00:18 home-test kernel: xhop
 > >> Dec 22 16:00:18 home-test kernel: <=
 > >> Dec 22 16:00:18 home-test kernel: 0, c
 > >> Dec 22 16:00:18 home-test kernel: able
 > >>     
 > >
 > > Do the lines get folded on the console, or only in /var/log/messages?
 > >   
 > 
 > As far as I can see, the console messages are fine.  It's only the 
 > messages that get
 > garbled.
 
 Perhaps an artifact of syslogd?