Date: Fri, 30 Oct 2015 21:58:37 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r290220 - head/share/mk Message-ID: <372E031B-090F-44FD-AD18-DF84767C1A77@gmail.com> In-Reply-To: <563435E1.9020108@FreeBSD.org> References: <201510310207.t9V27U7U051752@repo.freebsd.org> <CAGHfRMByPoGRZbF5_QYqePaGY_-BP6z2bG0C-zMEf-c8ZyfFgA@mail.gmail.com> <563435E1.9020108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 30, 2015, at 20:30, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >=20 >> On Oct 30, 2015, at 19:18, NGie Cooper <yaneurabeya@gmail.com> wrote: >>=20 >>> On Fri, Oct 30, 2015 at 7:07 PM, Bryan Drewery = <bdrewery@freebsd.org> wrote: >>> Author: bdrewery >>> Date: Sat Oct 31 02:07:30 2015 >>> New Revision: 290220 >>> URL: https://svnweb.freebsd.org/changeset/base/290220 >>>=20 >>> Log: >>> Don't hide stderr when checking ${CC} --version. >>>=20 >>> This can have important debugging information such as 'cc: not = found' or >>> 'ccache: error: Could not find compiler "cc" in PATH'. >>=20 >> Won't this spam installworld/distribution a lot? >=20 > Not for me. >=20 > What do you expect from stderr that is non-fatal? The only cases I've > had so far resulted in the .error triggering later due to not being = able > to determine compiler type. >=20 > Also, install depending on the compiler type is wrong. We need to > eliminate the cases where it determines SUBDIR or FILES to fix this. = I'd > like to effectively set CC=3Dfalse during install but can't while = those > checks exist. I=92ll have to run the build again. I=92ve seen a lot of noise without = it redirected to /dev/null in the past, but it=92s likely ok. I=92d like CC=3Dfalse to work too with installworld/distribution. I = think it=92s really bad that it=92s not the default variable right now = because it could cause things to get recompiled at install, which = inevitably leads to confusing emails later from end-users.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?372E031B-090F-44FD-AD18-DF84767C1A77>