From owner-cvs-ports@FreeBSD.ORG Sun Apr 13 21:44:38 2008 Return-Path: Delivered-To: cvs-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCAA2106564A; Sun, 13 Apr 2008 21:44:38 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 684248FC1A; Sun, 13 Apr 2008 21:44:38 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 4305328448; Mon, 14 Apr 2008 05:44:37 +0800 (CST) Received: from localhost (tarsier.geekcn.org [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id C66CAEB14EF; Mon, 14 Apr 2008 05:44:36 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id Sww7aBlj7kAB; Mon, 14 Apr 2008 05:44:30 +0800 (CST) Received: from charlie.delphij.net (c-69-181-135-56.hsd1.ca.comcast.net [69.181.135.56]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id E930AEB1495; Mon, 14 Apr 2008 05:44:28 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=RxPtC5NGko3ONJNL1wD/+6LFP/7pytVGw+eW6fFW4xaIjydxUl5mmOHFXUz4JVlso X3DLOY3eFiGS1hKAqTh8Q== Message-ID: <48027EB8.4020105@delphij.net> Date: Sun, 13 Apr 2008 14:44:24 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080312) MIME-Version: 1.0 To: Christian Weisgerber References: <200804121532.m3CFW1kh078688@repoman.freebsd.org> <4801BE6A.9090902@delphij.net> <20080413190643.GA31023@kemoauc.mips.inka.de> In-Reply-To: <20080413190643.GA31023@kemoauc.mips.inka.de> X-Enigmail-Version: 0.95.6 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.ORG, d@delphij.net, cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/misc/findutils Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 21:44:38 -0000 Christian Weisgerber wrote: > Xin LI: > >>> Work around the assumption that openat() implies the existence of >>> fdopendir(). FreeBSD 8 has the former, but not the latter. >> What about just implementing it instead? I have a hackish patch for this. > > Maybe, but this is outside the purview of ports. > I also think the merits of having fdopendir(3) should be judged > independently of the latest GNU breakage. Yes I agree. I'll ask review for my patch before committing it against -HEAD. What I feel a bit concern is that if we force configure script not to use openat() we may lose the chance that these functions get exercised which will not be good Perhaps something like BROKEN would be better because they will be checked later, but that's only my $0.02 :) Cheers, -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve!