Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Oct 2021 16:09:11 GMT
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 9da7cdecf101 - stable/12 - Disable PIE for powerpc bootloaders.
Message-ID:  <202110081609.198G9Bj3002213@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=9da7cdecf101ef70b30364479c35a9d25b47b576

commit 9da7cdecf101ef70b30364479c35a9d25b47b576
Author:     Marcin Wojtas <mw@FreeBSD.org>
AuthorDate: 2021-02-23 12:42:26 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2021-10-08 08:14:33 +0000

    Disable PIE for powerpc bootloaders.
    
    Bootloaders for powerpc are not built as position independent
    code. Since bsd.prog.mk is used for building, when PIE is enabled,
    the PIE flags are added and that causes the build to fail.
    Adding MK_PIE=no stops bsd.prog.mk from adding PIE specific flags.
    
    Submitted by: Dawid Gorecki <dgr@semihalf.com>
    Reviewed by: emaste
    Obtained from: Semihalf
    Sponsored by: Stormshield
    Differential Revision: https://reviews.freebsd.org/D28893
    
    (cherry picked from commit 3aa023643e9db78f4da314ff9bfb1643533c004f)
---
 stand/powerpc/boot1.chrp/Makefile | 2 ++
 stand/powerpc/kboot/Makefile      | 2 ++
 stand/powerpc/ofw/Makefile        | 2 ++
 stand/powerpc/uboot/Makefile      | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/stand/powerpc/boot1.chrp/Makefile b/stand/powerpc/boot1.chrp/Makefile
index 8fbc1e597119..d4f945a36989 100644
--- a/stand/powerpc/boot1.chrp/Makefile
+++ b/stand/powerpc/boot1.chrp/Makefile
@@ -30,5 +30,7 @@ boot1.hfs: boot1.elf bootinfo.txt
 
 CLEANFILES+= boot1.hfs
 
+MK_PIE=		no
+
 .include <bsd.prog.mk>
 
diff --git a/stand/powerpc/kboot/Makefile b/stand/powerpc/kboot/Makefile
index 671db88a14a9..0c6caeb84cd7 100644
--- a/stand/powerpc/kboot/Makefile
+++ b/stand/powerpc/kboot/Makefile
@@ -39,4 +39,6 @@ LDFLAGS=	-nostdlib -static -T ${.CURDIR}/ldscript.powerpc
 DPADD=		${LDR_INTERP} ${LIBOFW} ${LIBFDT} ${LIBSA}
 LDADD=		${LDR_INTERP} ${LIBOFW} ${LIBFDT} ${LIBSA}
 
+MK_PIE=		no
+
 .include <bsd.prog.mk>
diff --git a/stand/powerpc/ofw/Makefile b/stand/powerpc/ofw/Makefile
index 35c9d4ae546f..3d191b3ffbb5 100644
--- a/stand/powerpc/ofw/Makefile
+++ b/stand/powerpc/ofw/Makefile
@@ -45,4 +45,6 @@ CFLAGS+=	-I${BOOTSRC}/libofw
 DPADD=		${LDR_INTERP} ${LIBOFW} ${LIBFDT} ${LIBSA}
 LDADD=		${LDR_INTERP} ${LIBOFW} ${LIBFDT} ${LIBSA}
 
+MK_PIE=		no
+
 .include <bsd.prog.mk>
diff --git a/stand/powerpc/uboot/Makefile b/stand/powerpc/uboot/Makefile
index ccffd0ec1467..4787b5a48c68 100644
--- a/stand/powerpc/uboot/Makefile
+++ b/stand/powerpc/uboot/Makefile
@@ -30,4 +30,6 @@ LDFLAGS=	-nostdlib -static -T ${.CURDIR}/ldscript.powerpc
 DPADD=		${LDR_INTERP} ${LIBUBOOT} ${LIBFDT} ${LIBUBOOT_FDT} ${LIBSA}
 LDADD=		${LDR_INTERP} ${LIBUBOOT} ${LIBFDT} ${LIBUBOOT_FDT} ${LIBSA}
 
+MK_PIE=		no
+
 .include <bsd.prog.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202110081609.198G9Bj3002213>