From owner-svn-src-all@FreeBSD.ORG Fri Apr 24 20:35:05 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8CABE744; Fri, 24 Apr 2015 20:35:05 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 008E31FBA; Fri, 24 Apr 2015 20:35:04 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t3OKYx76015966 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 24 Apr 2015 23:34:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t3OKYx76015966 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t3OKYxxo015965; Fri, 24 Apr 2015 23:34:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 24 Apr 2015 23:34:59 +0300 From: Konstantin Belousov To: Antoine Brodin Cc: Will Andrews , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281442 - head/sys/kern Message-ID: <20150424203459.GA2390@kib.kiev.ua> References: <201504111851.t3BIpgRS071392@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2015 20:35:05 -0000 On Thu, Apr 23, 2015 at 09:53:19PM +0200, Antoine Brodin wrote: > On Sat, Apr 11, 2015 at 8:51 PM, Will Andrews wrote: > > Author: will > > Date: Sat Apr 11 18:51:41 2015 > > New Revision: 281442 > > URL: https://svnweb.freebsd.org/changeset/base/281442 > > > > Log: > > uiomove_object_page(): Avoid instantiating pages in sparse regions on reads. > > > > Check whether the page being requested is either resident or on swap. If > > not, read from the zero_region instead of instantiating an unnecessary page. > > > > This avoids consuming memory for sparse files on tmpfs, when they are read > > by applications that do not use SEEK_HOLE/SEEK_DATA (which is most of them). > > > > Reviewed by: kib > > MFC after: 1 week > > Sponsored by: Spectra Logic > > Hi, > > We have a daily panic on one of the package builders: > https://reviews.freebsd.org/P60 > > Reverting this commit seems to fix the panic. I already provided the following patch to gjb. I am waiting for a confirmation to commit. diff --git a/sys/kern/uipc_shm.c b/sys/kern/uipc_shm.c index 8410ed9..93c7ed1 100644 --- a/sys/kern/uipc_shm.c +++ b/sys/kern/uipc_shm.c @@ -170,7 +170,7 @@ uiomove_object_page(vm_object_t obj, size_t len, struct uio *uio) if (uio->uio_rw == UIO_READ && vm_page_lookup(obj, idx) == NULL && !vm_pager_has_page(obj, idx, NULL, NULL)) { VM_OBJECT_WUNLOCK(obj); - return (uiomove(__DECONST(void *, zero_region), len, uio)); + return (uiomove(__DECONST(void *, zero_region), tlen, uio)); } /*