From owner-freebsd-net  Tue Apr 25 17:55: 8 2000
Delivered-To: freebsd-net@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id 59CAD37B6F1; Tue, 25 Apr 2000 17:55:06 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.3/8.9.2) id RAA55462;
	Tue, 25 Apr 2000 17:55:05 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <200004260055.RAA55462@bubba.whistle.com>
Subject: Re: Proposal for ethernet, bridging, netgraph
In-Reply-To: <200004251652.SAA40276@luxren2.boostworks.com> from Remy Nonnenmacher at "Apr 25, 2000 06:52:24 pm"
To: luigi@FreeBSD.ORG, remy@boostworks.com, csg@waterspout.com,
	pavel@alum.mit.edu, nsayer@sftw.com, julian@elischer.org
Date: Tue, 25 Apr 2000 17:55:05 -0700 (PDT)
Cc: freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Archie Cobbs writes:
> OK, here's a patch ready for review & test.. this patch does one
> thing, which is move the calls to BPF and BRIDGE'ing out of each
> Ethernet driver and into ether_input().

Thanks for the input! The patch has been updated..

  ftp://ftp.whistle.com/pub/archie/misc/net.cleanup.patch.2

Again, the only purpose of this patch is to move the BPF and
BRIDGE taps out of the individual ethernet drivers and up into
ether_input().

Changes to the patch include:

  - If the 'eh' parameter to ether_input() is NULL, then don't
    do any of the link-layer stuff. This allows the existing
    optimization in the if_ed.c driver to work the same.

  - Smaller change to the optimization in if_ed.c: simply NULL
    out 'eh' before calling ether_input()

  - Changed bridge_in() and bridge_dst_lookup() prototypes to
    take a struct ether_header * instead of an mbuf

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message