From owner-freebsd-amd64@FreeBSD.ORG Sun Jul 3 00:47:55 2005 Return-Path: X-Original-To: freebsd-amd64@freebsd.org Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1642816A454; Sun, 3 Jul 2005 00:47:55 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29B21442EE; Sun, 3 Jul 2005 00:30:25 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 53D4B6551E; Sat, 2 Jul 2005 17:29:09 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id B19C35CA08 for ; Tue, 2 Nov 2004 18:34:55 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 3234E554AB; Wed, 3 Nov 2004 02:34:55 +0000 (GMT) (envelope-from owner-freebsd-current@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 58F1016A503; Wed, 3 Nov 2004 02:34:49 +0000 (GMT) Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D472B16A4CE; Wed, 3 Nov 2004 02:34:44 +0000 (GMT) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED4EB43D45; Wed, 3 Nov 2004 02:34:43 +0000 (GMT) (envelope-from doconnor@gsoft.com.au) Received: from inchoate.gsoft.com.au (localhost [127.0.0.1]) (authenticated bits=0) by cain.gsoft.com.au (8.12.11/8.12.10) with ESMTP id iA32YWtH008815; Wed, 3 Nov 2004 13:04:32 +1030 (CST) (envelope-from doconnor@gsoft.com.au) From: "Daniel O'Connor" To: freebsd-current@freebsd.org, John-Mark Gurney User-Agent: KMail/1.7 References: <34cb7c8404110209563fc01498@mail.gmail.com> <20041102190851.GR22681@funkthat.com> In-Reply-To: <20041102190851.GR22681@funkthat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6075508.at3aiTZfpd"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200411031304.31518.doconnor@gsoft.com.au> X-Scanned-By: MIMEDefang 2.16 (www . roaringpenguin . com / mimedefang) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-freebsd-current@freebsd.org Errors-To: owner-freebsd-current@freebsd.org X-Spam-Checker-Version: SpamAssassin 3.0.0 (2004-09-13) on elvis.mu.org X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.0 X-Spam-Level: Cc: peadar@freebsd.org, Peter Edwards , FreeBSD current mailing list , freebsd-amd64@freebsd.org Subject: Re: if_sk patch to get more info from people with problems X-BeenThere: freebsd-amd64@freebsd.org List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 00:47:55 -0000 X-Original-Date: Wed, 3 Nov 2004 13:04:30 +1030 X-List-Received-Date: Sun, 03 Jul 2005 00:47:55 -0000 --nextPart6075508.at3aiTZfpd Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wed, 3 Nov 2004 05:38, John-Mark Gurney wrote: > Peter Edwards wrote this message on Tue, Nov 02, 2004 at 17:56 +0000: > > A (very) quick look at the source reveals that buffers are allocated > > via sk_rxeof()->sk_newbuf()->sk_jalloc() in the interrupt receive > > function, with the softc lock held in sk_rxeof(). > > > > They're freed by the mbuf system via a call to sk_jfree(), but that > > doesn't hold the SK_LOCK. Is this possibly the source of the > > corruption problems? What am I missing? > > This compiles, anyway :-) > > Well, try the attached patch (it also includes my changes from a previous > diff) that will see what happens... Make sure you have your kernel > compiled with WITNESS and INVARIANTS... If you hit one of these > asserts, make sure you post the back trace... I didn't see the previous patch, but I applied it from this one to 4.x and = it=20 seems to be behaving itself now. I'll keep testing it, but previously it would lock up pretty quickly :) =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart6075508.at3aiTZfpd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBiEO35ZPcIHs/zowRAqmIAJ9ukCzqgBKkmsJPztDSTdueJAdTjQCgjjH4 o92QPeHXyjlvAKPIjKEbhQU= =3lPf -----END PGP SIGNATURE----- --nextPart6075508.at3aiTZfpd--