Date: Sat, 2 Mar 1996 23:36:27 +0900 (JST) From: enami@ba2.so-net.or.jp To: FreeBSD-gnats-submit@freebsd.org Subject: bin/1056: pppd failes if -detach Message-ID: <199603021436.XAA00902@euphoria.enami.ba2.so-net.or.jp> Resent-Message-ID: <199603021440.GAA16755@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 1056
>Category: bin
>Synopsis: pppd fails if -detach
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 2 06:40:01 PST 1996
>Last-Modified:
>Originator: enami tsugutomo
>Organization:
a hacker in japan
>Release: FreeBSD 2.2-CURRENT i386
>Environment:
FreeBSD 2.2, 486DX2, 12M mem, ...
>Description:
pppd failes to set control terminal if -detach option is given.
>How-To-Repeat:
Run pppd with -detach option.
>Fix:
I think there is no need to set control terminal if pppd doesn't
detached.
*** main.c 1996/03/02 13:36:46 1.1
--- main.c 1996/03/02 13:37:20
***************
*** 329,335 ****
hungup = 0;
kill_link = 0;
! if (!default_device)
setsid();
/* run connection script */
--- 329,335 ----
hungup = 0;
kill_link = 0;
! if (!default_device && !nodetach)
setsid();
/* run connection script */
***************
*** 360,366 ****
set_up_tty(fd, 0);
/* attach to the controlling tty for signals */
! if (!default_device && ioctl(fd, TIOCSCTTY) < 0) {
syslog(LOG_ERR, "ioctl(TIOCSCTTY) : %m");
die(1);
}
--- 360,366 ----
set_up_tty(fd, 0);
/* attach to the controlling tty for signals */
! if (!default_device && !nodetach && ioctl(fd, TIOCSCTTY) < 0) {
syslog(LOG_ERR, "ioctl(TIOCSCTTY) : %m");
die(1);
}
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199603021436.XAA00902>