From owner-cvs-all Sun Oct 28 1:21:56 2001 Delivered-To: cvs-all@freebsd.org Received: from silby.com (cb34181-a.mdsn1.wi.home.com [24.14.173.39]) by hub.freebsd.org (Postfix) with ESMTP id F253037B405 for ; Sun, 28 Oct 2001 01:21:51 -0800 (PST) Received: (qmail 95601 invoked by uid 1000); 28 Oct 2001 09:21:51 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 28 Oct 2001 09:21:51 -0000 Date: Sun, 28 Oct 2001 03:21:51 -0600 (CST) From: Mike Silbersack To: Poul-Henning Kamp Cc: Greg Lehey , , Jonathan Lemon , "Andrey A. Chernov" , , Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) In-Reply-To: <31874.1004258544@critter.freebsd.dk> Message-ID: <20011028031839.U95596-100000@achilles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 28 Oct 2001, Poul-Henning Kamp wrote: > >So why haven't you fixed it? > > Because it is not my task to fix all broken drivers. > > The message is "WARNING: driver mistake ..." for a very good reason. > > For instance, I can see the bogus code (mentioned earlier) in asr.c > but since I have no hardware I cannot test my hypothesis that the > entire driverinit function can be removed. Well, since this is the point of contention, could we just comment out the code in driverinit and send the maintainer an e-mail about cleaning it up? I think it's fair to possibly break asr for a little while if it removes the possibility that a GENERIC kernel will panic on everyone. As of now, this is the only error I'm seeing, and PHK's panic policy for these types of errors sounds like it will be productive. So, let's blame/patch asr and move on. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message