Date: Wed, 11 May 2016 16:59:09 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r299480 - head/secure/lib/libcrypto Message-ID: <24a71d4d-a500-16e1-be67-4374bbdf3307@FreeBSD.org> In-Reply-To: <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com> References: <201605112006.u4BK6NNd095917@repo.freebsd.org> <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO Content-Type: multipart/mixed; boundary="JbpsG7WC3GR5Tmb9xlCqxWxd4pEFsMexx" From: Jung-uk Kim <jkim@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <24a71d4d-a500-16e1-be67-4374bbdf3307@FreeBSD.org> Subject: Re: svn commit: r299480 - head/secure/lib/libcrypto References: <201605112006.u4BK6NNd095917@repo.freebsd.org> <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com> In-Reply-To: <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com> --JbpsG7WC3GR5Tmb9xlCqxWxd4pEFsMexx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/11/16 04:43 PM, Ed Maste wrote: > On 11 May 2016 at 16:06, Jung-uk Kim <jkim@freebsd.org> wrote: >> Author: jkim >> Date: Wed May 11 20:06:23 2016 >> New Revision: 299480 >> URL: https://svnweb.freebsd.org/changeset/base/299480 >> > [...] >> ( echo '# $$'FreeBSD'$$' ;\ >> echo '# Do not modify. This file is auto-generated from ${.IMP= SRC:T}.' ;\ >> echo '#ifdef PIC' ;\ >> - perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\ >> + env CC=3Dcc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -D= PIC ;\ >> echo '#else' ;\ >> - perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\ >> + env CC=3Dcc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\ >=20 > One thing that occurred to me in the older PIC change here: perhaps we > should explicitly strip -fpic / -DPIC from the passed-in ${CFLAGS} for > the #else. It's unlikely, but possible, that a user could regenerate > the assembly files with -fpic set in CFLAGS. No user serviceable parts inside. ;-) Seriously, there's no need for overengineering this file. Jung-uk Kim --JbpsG7WC3GR5Tmb9xlCqxWxd4pEFsMexx-- --qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXM50dAAoJEHyflib82/FGdr4IAI5LaoyHPxKQnQAwtcR7jBNY hLadqSCur2/iUg5nHKUMcKw2w3LMGP202IG8tunuS/2RIURZdq0aeLuGUMB6Hfaa nD/z4RqQqHUrojqwyH7yeCZdPal/uQVjGJgeD5I/0Jip7K0CNQvupVwLfihcafST W3AquzFv6PDaJK12Orv7MHijlBa5N/bcPw8sPOfOlZ/83mR3ksk6FoNJHslyHj0I ypvQrQ5lMkyoQt912K2FeKbS86Wxav4vT2MRxBYRDZjVnT7pgZTBTf0R4lJ83oQb epHmgKTKcYTCr0WtnQqcMV+21tBLUliBptOjDmj+dfRp0b3iYzeIR2yrB3oVwdo= =znAV -----END PGP SIGNATURE----- --qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24a71d4d-a500-16e1-be67-4374bbdf3307>