From owner-cvs-src@FreeBSD.ORG Sun Jun 1 14:18:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52C3D37B401; Sun, 1 Jun 2003 14:18:21 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7892043F93; Sun, 1 Jun 2003 14:18:20 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h51LIGVm080144; Sun, 1 Jun 2003 14:18:16 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h51LIGmQ080143; Sun, 1 Jun 2003 14:18:16 -0700 (PDT) Date: Sun, 1 Jun 2003 14:18:16 -0700 From: "David O'Brien" To: Dag-Erling Smorgrav Message-ID: <20030601211816.GE79746@dragon.nuxi.com> References: <200306011831.h51IVQxD054651@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.1-BETA Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.sys.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jun 2003 21:18:21 -0000 On Sun, Jun 01, 2003 at 11:01:47PM +0200, Dag-Erling Smorgrav wrote: > "David E. O'Brien" writes: > > Modified files: > > share/mk bsd.sys.mk > > Log: > > Compile our code as C99 by default. > > Please back this out immediately. You can't possibly have tested it; > it breaks the build quite badly. Show me the failure. > I'd also like you to back out the previous commit (1.19), which made > CSTD pretty much useless. Take it to the TRB. It was useless before. One cannot even set CSTD=gnu89, which should be a NOP. The same failure occurs for *any* setting of CSTD because you were too agressive with -pedantic. Rev 1.19 returns behavior back to the behavior of the past year. # fgrep '$FreeBSD' /usr/share/mk/bsd.sys.mk # $FreeBSD: src/share/mk/bsd.sys.mk,v 1.17 2003/05/05 21:14:36 des Exp $ # cd /usr/src/sbin/adjkerntz/ # CSTD=gnu89 make cc -O -pipe -march=athlon-xp -std=gnu89 -pedantic -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /usr/src/sbin/adjkerntz/adjkerntz.c cc1: warnings being treated as errors In file included from /usr/src/sbin/adjkerntz/adjkerntz.c:52: /usr/include/sys/time.h: In function `timespec2bintime': /usr/include/sys/time.h:125: warning: ISO C89 forbids long long integer constants /usr/include/sys/time.h: In function `timeval2bintime': /usr/include/sys/time.h:142: warning: ISO C89 forbids long long integer constants /usr/src/sbin/adjkerntz/adjkerntz.c: In function `main': /usr/src/sbin/adjkerntz/adjkerntz.c:131: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:155: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:163: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:291: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:298: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:316: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:323: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:338: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:347: warning: ISO C does not support the `%m' printf format /usr/src/sbin/adjkerntz/adjkerntz.c:358: warning: ISO C does not support the `%m' printf format *** Error code 1 Stop in /usr/src/sbin/adjkerntz.