Date: Sun, 24 Aug 2008 18:01:27 +0200 From: Ed Schouten <ed@80386.nl> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c Message-ID: <20080824160127.GW99951@hoeg.nl> In-Reply-To: <alpine.BSF.1.10.0808241643320.28482@fledge.watson.org> References: <200808241006.m7OA6IbU072333@repoman.freebsd.org> <alpine.BSF.1.10.0808241643320.28482@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--9W0zaDh10igqoM3B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Robert Watson <rwatson@FreeBSD.org> wrote: > Do you plan to provide updated compat libs for 4.x, 5.x, 6.x, 7.x, to=20 > replace libc/libutil code that expects to be able to execute the pt_chown= =20 > binary? What happens if that code can't find the pt_chown binary it=20 > expects? I thought my commit message already explained this: > After some discussions back in June I changed the PTY code to set > permissions properly upon creation. Fortunately the previous grantpt() > implementation changed permissions by hand when pt_chown is not > installed, which always succeeds. This means grantpt() still works > properly, even though the set-uid utility is missing. There is no need for compat libraries, because the existing ones already do this: - Try to run pt_chown. - If that fails, try to chmod/chown the slave device by hand. - If that fails, return an error. Because the PTY that openpty() obtains already has the proper permissions in place, the second step won't fail. --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --9W0zaDh10igqoM3B Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkixhdcACgkQ52SDGA2eCwUPUACdE8m+gICu9sGz2bmluoCAfEXJ IAwAn27VTMqsBnsL72cbTecU49V7kOQD =0Q1Z -----END PGP SIGNATURE----- --9W0zaDh10igqoM3B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080824160127.GW99951>