From owner-freebsd-bugs@freebsd.org Sun Jun 14 09:33:40 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0CE3A33486E for ; Sun, 14 Jun 2020 09:33:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49l8R76dDYz49bv for ; Sun, 14 Jun 2020 09:33:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E37A83349D1; Sun, 14 Jun 2020 09:33:39 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E343E3349D0 for ; Sun, 14 Jun 2020 09:33:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49l8R75ndTz4B3k for ; Sun, 14 Jun 2020 09:33:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A765FA066 for ; Sun, 14 Jun 2020 09:33:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05E9XdUM034011 for ; Sun, 14 Jun 2020 09:33:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05E9XdBa034010 for bugs@FreeBSD.org; Sun, 14 Jun 2020 09:33:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 204521] [new driver] [request] Port rtsx from OpenBSD to FreeBSD Date: Sun, 14 Jun 2020 09:33:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: gnikl@justmail.de X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2020 09:33:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204521 gnikl@justmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gnikl@justmail.de --- Comment #217 from gnikl@justmail.de --- (In reply to commit-hook from comment #202) Build fails on 11.3. With the following patch the build succeeds: --cut-- --- rtsx.c~ 2020-06-11 16:47:01.000000000 +0200 +++ rtsx.c 2020-06-14 10:51:27.873097000 +0200 @@ -37,10 +37,12 @@ #include __FBSDID("$FreeBSD$"); +#include #include +#include +#include #include #include -#include #include #include #include --cut-- Note: The missing piece is "#include ". The other includes and= the reordering are gleaned from other kernel sources referencing eg. bootverbos= e. I have no idea if there is a preferred include order. Now the more interesting part: the driver works successfully with this devi= ce in a Fujitsu H730 laptop: rtsx0@pci0:4:0:0: class=3D0xff0000 card=3D0x187f10cf chip=3D0x522710e= c rev=3D0x01 hdr=3D0x00 vendor =3D 'Realtek Semiconductor Co., Ltd.' device =3D 'RTS5227 PCI Express Card Reader' The card status is detected properly, the inversion switch is not required. Reading from a msdosfs formatted 2GB card worked fine. Writing and suspend/resume was not tested yet. --=20 You are receiving this mail because: You are the assignee for the bug.=