From owner-svn-src-all@FreeBSD.ORG Sun Jul 27 07:11:18 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B7907453; Sun, 27 Jul 2014 07:11:18 +0000 (UTC) Received: from mail-pd0-x22f.google.com (mail-pd0-x22f.google.com [IPv6:2607:f8b0:400e:c02::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 80EF42DD1; Sun, 27 Jul 2014 07:11:18 +0000 (UTC) Received: by mail-pd0-f175.google.com with SMTP id r10so7996953pdi.34 for ; Sun, 27 Jul 2014 00:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=af22jETQiX843co+zeUsY+Jzd4tyNUUehAFXJzOHtGU=; b=t/qLTif7lsJcpcmMivozV7aNxDDgWGS+7wPoKFyxQw2yteQjGrO14fIaCol94nbZEF lmj89QWmGXvps9i60YdiSWHwYSs+qUENucPj3Ltq3TujHBPOh4vyRybrQhYett253cTZ WmYqt4Yy6Mmand1MyZJHm8l6slbRhgU6X4QFm8RHa2gwc6soV3e2umpoA+rRF5nR3ora 2BTDP4LpNVDbwoybT3XVXeFxE6JqUPtW36NVTYwZnudK7AYrXgb65VTlwjG8IoN/2bIm Tsip/ORRegY5mly6c1YB0OJ3MNXcaP6UcumFstoRkiWJqXFXH1M+vaWV4vV/6fYzbn6r HvYA== X-Received: by 10.68.173.65 with SMTP id bi1mr560501pbc.130.1406445077582; Sun, 27 Jul 2014 00:11:17 -0700 (PDT) Received: from ox ([24.6.44.228]) by mx.google.com with ESMTPSA id k9sm18498701pdo.28.2014.07.27.00.11.16 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 27 Jul 2014 00:11:17 -0700 (PDT) Sender: Navdeep Parhar Date: Sun, 27 Jul 2014 00:11:12 -0700 From: Navdeep Parhar To: Konstantin Belousov Subject: Re: svn commit: r269106 - head/tools/tools/cxgbetool Message-ID: <20140727071112.GA14128@ox> Mail-Followup-To: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201407260051.s6Q0pjNO077573@svn.freebsd.org> <20140726182607.GG93733@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140726182607.GG93733@kib.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2014 07:11:18 -0000 On Sat, Jul 26, 2014 at 09:26:07PM +0300, Konstantin Belousov wrote: > On Sat, Jul 26, 2014 at 12:51:45AM +0000, Navdeep Parhar wrote: > > Author: np > > Date: Sat Jul 26 00:51:45 2014 > > New Revision: 269106 > > URL: http://svnweb.freebsd.org/changeset/base/269106 > > > > Log: > > Add a 'raw' parameter to the 'modinfo' subcommand. This is handy when > > trying to figure out why a QSFP+/SFP+ connector or cable wasn't > > identified correctly by cxgbe(4). Its output looks like this: > > > > # cxgbetool t5nex0 modinfo 0 raw > > 00: 03 04 21 00 00 00 00 00 ..!. .... > > 08: 04 00 00 00 67 00 00 00 .... g... > > 10: 00 00 05 00 41 6d 70 68 .... Amph > > 18: 65 6e 6f 6c 20 20 20 20 enol > > 20: 20 20 20 20 00 41 50 48 .APH > > 28: 35 37 31 35 34 30 30 30 5715 4000 > > 30: 33 20 20 20 20 20 20 20 3 > > 38: 4b 20 20 20 01 00 00 fa K .... > > 40: 00 00 00 00 41 50 46 31 .... APF1 > > 48: 30 30 34 30 30 33 30 30 0040 0300 > > 50: 30 33 20 20 31 30 30 31 03 1001 > > 58: 33 30 20 20 00 00 00 97 30 .... > > > > MFC after: 3 days > > > > Modified: > > head/tools/tools/cxgbetool/cxgbetool.c > > I do not remember if this question was already asked. > > Why cxgbetool lives in tools and not installed into /usr/sbin as > cxgbecontrol(8) ? cxgbetool was originally meant to be just a debug tool, not something that would be of interest to most users (not even those using cxgbe). But once written, it offered an easy way to interface with the driver and chip, and so it gradually grew a number of commands for features for which there is no system CLI (packet filtering/steering, QoS-ish stuff, packet sniffing, pluggable optics/copper modules, etc.). In its current state I think it fits in tools/tools or usr/sbin equally well. Moving it to usr/sbin will force the issue of a manpage -- I have one that has been 80% complete for 2 years now :-( Regards, Navdeep