From owner-svn-src-stable@FreeBSD.ORG Tue Jun 1 20:37:53 2010 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5D42106564A; Tue, 1 Jun 2010 20:37:53 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id C2FB28FC1E; Tue, 1 Jun 2010 20:37:52 +0000 (UTC) Received: by fxm5 with SMTP id 5so4131426fxm.13 for ; Tue, 01 Jun 2010 13:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :x-comment-to:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=R6iEfN649xnq2hdKOvvpiAXN7betRezb9shtN7u4uv0=; b=iCV8JTZiXeEy1SdFVQytUV9PR/D57xHsyuauHde6UVZ8zH46udFmRslfUosapXFXCK 6FDH/y1OEmsv+/IQvDtn2MYVnreUiOGM8lx0T0WQcU9uFRft8VqYwE7kpSlk+MOEsOjT FdR3iPIC8ZL1G/Iz3WV/1U4tuMYM4DUQ52Xt0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=Zim37/rMb6GDQmvNmTz2EmwHgtr6BLURLBffGI1waOy/s1RVtMq07X+gHSvxNigoN4 QlRO/wzjQQFfPYhhMXT5AuZpPVP2iaMhEJxh8WULy9oT5/SOI5woR1zYh87f2mjRQw0l iUZv8u1zNg5/owAqQUzpL/KVT44EYLYEQAPRA= Received: by 10.204.48.195 with SMTP id s3mr1019232bkf.195.1275423280394; Tue, 01 Jun 2010 13:14:40 -0700 (PDT) Received: from localhost ([95.69.167.97]) by mx.google.com with ESMTPS id v2sm4636413bkz.19.2010.06.01.13.14.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 01 Jun 2010 13:14:39 -0700 (PDT) From: Mikolaj Golub To: "Robert N. M. Watson" References: <201006011359.o51DxmSW050166@svn.freebsd.org> <2E4C7566-1F0E-4A44-8514-061FF1E129DE@gmail.com> <57DF5801-1685-4C69-9FD3-E56F5425E28C@FreeBSD.org> X-Comment-To: Robert N. M. Watson Date: Tue, 01 Jun 2010 23:14:36 +0300 In-Reply-To: <57DF5801-1685-4C69-9FD3-E56F5425E28C@FreeBSD.org> (Robert N. M. Watson's message of "Tue, 1 Jun 2010 15:39:01 +0100") Message-ID: <86wrui4ij7.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nikolay Denev , svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org, svn-src-stable@freebsd.org Subject: Re: svn commit: r208692 - stable/8/sys/kern X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 20:37:53 -0000 On Tue, 1 Jun 2010 15:39:01 +0100 Robert N. M. Watson wrote: RNMW> On 1 Jun 2010, at 15:23, Nikolay Denev wrote: >>> When close() is called on a connected socket pair, SO_ISCONNECTED might be >>> set but be cleared before the call to sodisconnect(). In this case, >>> ENOTCONN is returned: suppress this error rather than returning it to >>> userspace so that close() doesn't report an error improperly. >>> >>> PR: kern/144061 >>> Reported by: Matt Reimer , >>> Nikolay Denev , >>> Mikolaj Golub >> I wonder, does this affect RELENG_7 ? (can't test at the moment, but sys/kern/uipc_socket.c:soclose() looks similar) RNMW> Yes, almost certainly -- if it doesn't manifest, it's just because of RNMW> timing differences, not because the bug isn't present. I'll look at RNMW> merging it to 7.x as well. Actually these were 7.1 servers where I noticed this problem fist. -- Mikolaj Golub