From owner-cvs-all  Thu May 23  0:35: 2 2002
Delivered-To: cvs-all@freebsd.org
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id F0F1037B40F; Thu, 23 May 2002 00:34:49 -0700 (PDT)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g4N7Ybv46799;
	Thu, 23 May 2002 10:34:37 +0300 (EEST)
	(envelope-from ru)
Date: Thu, 23 May 2002 10:34:37 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: John Baldwin <jhb@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern_mutex.c
Message-ID: <20020523073437.GC35465@sunbay.com>
References: <200205222032.g4MKWdl17723@freefall.freebsd.org> <20020523171421.L12695-100000@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="eHhjakXzOLJAF9wJ"
Content-Disposition: inline
In-Reply-To: <20020523171421.L12695-100000@gamplex.bde.org>
User-Agent: Mutt/1.3.99i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


--eHhjakXzOLJAF9wJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 23, 2002 at 05:21:49PM +1000, Bruce Evans wrote:
> On Wed, 22 May 2002, John Baldwin wrote:
>=20
> > jhb         2002/05/22 13:32:39 PDT
> >
> >   Modified files:
> >     sys/i386/include     cpufunc.h
> >     sys/kern             kern_mutex.c
> >   Log:
> >   Rename pause() to ia32_pause() so it doesn't conflict with the pause()
> >   function defined in <unistd.h>.  I didn't #ifdef _KERNEL it because t=
he
> >   mutex implementation in libpthread will probably need this.
>=20
> This shoots the messenger.  The main bug is gross namespace pollution in
> <vgl.h>:
>=20
> %%%
> #ifndef _VGL_H_
> #define _VGL_H_
>=20
> #include <stdlib.h>
> #include <unistd.h>
> #include <string.h>
> #include <machine/cpufunc.h>
> %%%
>=20
> <machine/cpufunc.h> is really a kernel-only header, but it sometimes gets
> abused in userland.  I think this shouldn't be supported.  It contains
> mostly very machine-dependent interfaces, so it should be used in at most
> the implementation of libvgl.  libvgl uses i386 interfaces unconditionall=
y,
> so it only works on i386's, but this limitation is not documented.
>=20
Would you like me to fix this by adding the share/man/man3/i386, and
installing this manpage to there?


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

--eHhjakXzOLJAF9wJ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE87JuNUkv4P6juNwoRAin4AKCMXwdU6cygDOXLhpB9IBVuX3NBCQCfTgRl
MM96cbDiHKzz0j+lUiHFLqM=
=ojix
-----END PGP SIGNATURE-----

--eHhjakXzOLJAF9wJ--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message