From owner-freebsd-security  Mon Nov 13 10:45:12 1995
Return-Path: owner-security
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id KAA17720
          for security-outgoing; Mon, 13 Nov 1995 10:45:12 -0800
Received: from halloran-eldar.lcs.mit.edu (halloran-eldar.lcs.mit.edu [18.26.0.159])
          by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id KAA17714
          for <security@freebsd.org>; Mon, 13 Nov 1995 10:45:10 -0800
Received: by halloran-eldar.lcs.mit.edu; (5.65/1.1.8.2/19Aug95-0530PM)
	id AA19662; Mon, 13 Nov 1995 13:42:21 -0500
Date: Mon, 13 Nov 1995 13:42:21 -0500
From: "Garrett A. Wollman" <wollman@lcs.mit.edu>
Message-Id: <9511131842.AA19662@halloran-eldar.lcs.mit.edu>
To: Peter Wemm <peter@jhome.DIALix.COM>
Cc: security@freebsd.org
Subject: Re: cvs commit: CVSROOT log_accum.pl 
In-Reply-To: <Pine.BSF.3.91.951114020403.353D-100000@jhome.DIALix.COM>
References: <199511131630.IAA04150@corbin.Root.COM>
	<Pine.BSF.3.91.951114020403.353D-100000@jhome.DIALix.COM>
Sender: owner-security@freebsd.org
Precedence: bulk

[VM-mail-mode went insane on me when I tried to send this last time.
Let's try again.]

<<On Tue, 14 Nov 1995 02:26:45 +0800 (WST), Peter Wemm <peter@jhome.DIALix.COM> said:

> BTW: I suspect "struct ucred" should be reordered for better internal 
> alignment..  
> It is currently:
> struct ucred {
>   short cr_ref;
>   long  cr_uid;
>   short cr_ngroups;
>   long  cr_groups[NGROUPS];
> }
> The order of cr_ngroups and cr_uid could be swapped making the whole 
> thing 4 bytes smaller (assuming that I understand structure packing.. :-)

Better to make the shorts into longs if you're going to change the
structure.  shorts are slow.

-GAWollman

--
Garrett A. Wollman   | Shashish is simple, it's discreet, it's brief. ... 
wollman@lcs.mit.edu  | Shashish is the bonding of hearts in spite of distance.
Opinions not those of| It is a bond more powerful than absence.  We like people
MIT, LCS, ANA, or NSA| who like Shashish.  - Claude McKenzie + Florent Vollant