Date: Sun, 31 Dec 2017 09:08:57 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457632 - in head/lang/guile2: . files Message-ID: <20171231090857.GA6651@FreeBSD.org> In-Reply-To: <r2rb-qnb5-wny@FreeBSD.org> References: <201712301912.vBUJCdtc086342@repo.freebsd.org> <1sjc-ylsz-wny@FreeBSD.org> <20171231084028.GA98479@FreeBSD.org> <r2rb-qnb5-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 31, 2017 at 10:06:06AM +0100, Jan Beich wrote: > Alexey Dokuchaev <danfe@FreeBSD.org> writes: > > > On Sat, Dec 30, 2017 at 09:59:08PM +0100, Jan Beich wrote: > > > >> Alexey Dokuchaev <danfe@FreeBSD.org> writes: > >> > >> > ++/* With old GCC, do not override _Static_assert: it conflicts with > >> > ++ #include <complex.h> below. */ > >> > ++#if __clang__ || (__GNUC__ >= 4 && __GNUC_MINOR__ >= 6) > >> > >> - GCC check for minor version rejects 5.4, 6.4, 7.2 > >> - Clang check needs defined() to pacify -Wundef with GCC > >> > >> libguile/numbers.c:50:5: warning: "__clang__" is not defined, evaluates > >> to 0 [-Wundef] > >> #if __clang__ || (__GNUC__ >= 4 && __GNUC_MINOR__ >= 6) > >> ^~~~~~~~~ > > > > How about this: > > > > #if defined(__clang__) || (__GNUC__ * 10 + __GNUC_MINOR__ >= 46) > > ... ? > > Looks OK. None of lang/gcc* ports have __GNUC_MINOR__ >= 10. Yes, I was a bit worried if 10 is enough, but found no offending versions. It also matches the format of COMPILER_VERSION. So be it then, thank you. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171231090857.GA6651>