Date: Fri, 26 Jul 2019 20:03:49 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r350135 - head/share/mk Message-ID: <2eaac343-b3ef-4910-65e2-b9b0c7886029@FreeBSD.org> In-Reply-To: <20190726052345.560b122cf2714bef73a2bf4f@bidouilliste.com> References: <201907191511.x6JFBWVi053537@repo.freebsd.org> <37944eff-6e00-df14-59d3-beae3fa89b6a@FreeBSD.org> <28eb9717-533e-3d87-0e30-f60317ed97cb@FreeBSD.org> <20190726051042.fcc4f6d969e19fb6f480977b@bidouilliste.com> <0e851350-0967-ee2b-3655-b79d9abd38ed@FreeBSD.org> <20190726052345.560b122cf2714bef73a2bf4f@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26/07/19 05:23, Emmanuel Vadot wrote:
> On Fri, 26 Jul 2019 14:58:01 +0200
> Guido Falsi <madpilot@FreeBSD.org> wrote:
>>>>> Hello,
>>>>>
>>>>> I don't know the actual workings of this file and have not checked it in
>>>>> depth, but this change is causing "make package" to not package
>>>>> /etc/rc.d/sshd (and others, all the ones being defined in
>>>>> ${group}PACKAGE variables), which are then missing when upgrading machines.
>>>>>
>>>>> Reverting this change makes packaging things work again. I think this
>>>>> change is actually wrong and the previous version was correct.
>>>>>
>>>
>>> /etc/rc.d/sshd is in the FreeBSD-sshd package, the other ones are also
>>> in their own package now, I'll check them all to see if that make sense.
>>
>> It makes perfect sense for that file to be in the FreeBSD-sshd package
>> and that was my first guess when looking for the missing file, but in my
>> case it was not present in that package.
>>
>> By reverting your change it appears to end up in the FreeBSD-runtime
>> package.
>
> Fresh build from today :
>
> elbarto@wopr> tar tzf FreeBSD-ssh-13.0.s20190726081149.txz /etc/rc.d/sshd
> /etc/rc.d/sshd
> elbarto@wopr> tar xzf FreeBSD-ssh-13.0.s20190726081149.txz +MANIFEST
> elbarto@wopr> jq < +MANIFEST | grep sshd
> "/etc/rc.d/sshd": "1$09d051563f89dbae0f54af42add15f9c16d5bf5c63a32d8eadc5127f665e4de9",
> "/etc/ssh/sshd_config": "1$7501d70e5186360c812b55cf0f0caff51169ca6764222f3fa668c09e8b5823a8",
> "/usr/sbin/sshd": "1$85772d32ba83cf6edd190fe48e949a358b08079a1dcc2c6a0de9addfe5075829",
> "/usr/share/man/man5/sshd_config.5.gz": "1$593bcd2338b124faf735825c52da8d9534f3e4b326a573590e8625f364017b57",
> "/usr/share/man/man8/sshd.8.gz": "1$729b894da4fa632be0ca6e06897943caca0e9d699a8a3c0ed33393e0b7ecec44",
> "/etc/rc.d/sshd",
> "/etc/ssh/sshd_config"
A new build gives me the same result as you.
Unluckily I don't have the old packages without the files anymore (my
mistake). I have no idea what has been going on.
Sorry for the noise and thanks for having listened to me!
--
Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2eaac343-b3ef-4910-65e2-b9b0c7886029>