From owner-cvs-all@FreeBSD.ORG Mon May 14 13:41:14 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DE1E116A400; Mon, 14 May 2007 13:41:14 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 8A2F113C448; Mon, 14 May 2007 13:41:14 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54a5d654.dip.t-dialin.net [84.165.214.84]) by redbull.bpaserver.net (Postfix) with ESMTP id A6CB22E136; Mon, 14 May 2007 15:41:06 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id F250D5B48A3; Mon, 14 May 2007 15:40:40 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l4EDeeWH080393; Mon, 14 May 2007 15:40:40 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Mon, 14 May 2007 15:40:40 +0200 Message-ID: <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Mon, 14 May 2007 15:40:40 +0200 From: Alexander Leidinger To: Dag-Erling Smorgrav References: <200705131815.l4DIFop9026874@repoman.freebsd.org> In-Reply-To: <200705131815.l4DIFop9026874@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2007 13:41:15 -0000 Quoting Dag-Erling Smorgrav (from Sun, 13 May 2007 =20 18:15:50 +0000 (UTC)): > des 2007-05-13 18:15:50 UTC > > FreeBSD src repository > > Modified files: > . Makefile.inc1 > Log: > Greatly speed up {check,delete}-old* by replacing make loops with sh loo= ps. How much faster? Thanks for tackling this. Some review: Why did you remove the echo? Why do you redirect stderr of chflags to /dev/null? Why did you change the removal logic? The way it was before: - rm (without -i if requested) - if rm fails do a chflags and rm again (bug: if user says no in the =20 interactive mode, the chlags is done regardless) - tell the user about the stuff we do (removing flags) - it aborts on a failure of the second rm (AFAIR) The way it is now: - for every file do a chflags without notifying the user, don't tell =20 about problems - rm (without -i if requested) - bug(?): ${DESTDIR} in the rm line - doesn't abort on rm failure - has the same bug that it chflags even if the user doesn't want to =20 rm the file Before it was possible for the user to readd the flags, now the user =20 doesn't know about this. I also worry about the abort on failure part =20 which does not exist anymore. The last part was done on purpose, the =20 former part was nice to have (because of the bug) and the printing of =20 what is going on in this part was on purpose. Bye, Alexander. --=20 We read to say that we have read. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137