Date: Fri, 26 Jan 2001 08:23:47 +0200 From: Mark Murray <mark@grondar.za> To: Mike Heffner <mheffner@vt.edu> Cc: FreeBSD-audit <FreeBSD-audit@FreeBSD.ORG> Subject: Re: lam(1) patch Message-ID: <200101260624.f0Q6NZW05123@gratis.grondar.za> In-Reply-To: <XFMail.20010126005836.mheffner@vt.edu> ; from Mike Heffner <mheffner@vt.edu> "Fri, 26 Jan 2001 00:58:36 EST." References: <XFMail.20010126005836.mheffner@vt.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> The following patch fixes the following: > > - sprintf() -> snprintf() > - manual (unbounded) while() loop string copying -> strlcpy() > - use tolower() rather than bit or'ing > - sanity check the user specified printf() format > - prevent walking off end of inputfile array > - some other string bounds issues > > Reviews please? Looks cool to me. While you are in there, you probably also want to blow away the "register" keyword(s) on the lines you are messing with. M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101260624.f0Q6NZW05123>