Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 May 2016 17:50:27 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        "Bjoern A. Zeeb" <bz@FreeBSD.org>, Andrew Turner <andrew@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci
Message-ID:  <afefe83a-df9c-b2fc-73d0-0e3b3dae6d60@FreeBSD.org>
In-Reply-To: <ADDCB1BB-E6BC-4010-AF38-4264EB6AEF81@FreeBSD.org>
References:  <201605111707.u4BH7UXs040026@repo.freebsd.org> <ADDCB1BB-E6BC-4010-AF38-4264EB6AEF81@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--dbepT12CGabjDgX7GV0qt71I7DPxJbh8V
Content-Type: multipart/mixed; boundary="gkT1gpbFKCewVB3FHhdWldx0PuEhlWnwK"
From: Jung-uk Kim <jkim@FreeBSD.org>
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>, Andrew Turner <andrew@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Message-ID: <afefe83a-df9c-b2fc-73d0-0e3b3dae6d60@FreeBSD.org>
Subject: Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci
References: <201605111707.u4BH7UXs040026@repo.freebsd.org>
 <ADDCB1BB-E6BC-4010-AF38-4264EB6AEF81@FreeBSD.org>
In-Reply-To: <ADDCB1BB-E6BC-4010-AF38-4264EB6AEF81@FreeBSD.org>

--gkT1gpbFKCewVB3FHhdWldx0PuEhlWnwK
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 05/11/16 05:38 PM, Bjoern A. Zeeb wrote:
>=20
>> On 11 May 2016, at 17:07 , Andrew Turner <andrew@freebsd.org> wrote:
>>
>> Author: andrew
>> Date: Wed May 11 17:07:29 2016
>> New Revision: 299467
>> URL: https://svnweb.freebsd.org/changeset/base/299467
>>
>> Log:
>>  Add a new get_id interface to pci and pcib. This will allow us to bot=
h
>>  detect failures, and get different PCI IDs.
>>
>>  For the former the interface returns an int to signal an error. The I=
D is
>>  returned at a uintptr_t * argument.
>>
>>  For the latter there is a type argument that allows selecting the ID =
type.
>>  This only specifies a single type, however a MSI type will be added
>>  to handle the need to find the ID the hardware passes to the ARM GICv=
3
>>  interrupt controller.
>>
>>  A follow up commit will be made to remove pci_get_rid.
>>
>>  Reviewed by:	jhb, rstone
>>  Obtained from:	ABT Systems Ltd
>>  Sponsored by:	The FreeBSD Foundation
>>  Differential Revision:	https://reviews.freebsd.org/D6239
>=20
> Hi, seems gcc, I guess it is, doesn=E2=80=99t like your change:
>=20
> In file included from /scratch/tmp/bz/head.svn/sys/sparc64/isa/ofw_isa.=
c:78:
> ./pcib_if.h:166: warning: 'enum pci_id_type' declared inside parameter =
list
> ./pcib_if.h:166: warning: its scope is only this definition or declarat=
ion, which is probably not what you want
> ./pcib_if.h:169: warning: 'enum pci_id_type' declared inside parameter =
list
> ./pcib_if.h:169: error: parameter 3 ('type') has incomplete type
> ./pcib_if.h: In function 'PCIB_GET_ID':
> ./pcib_if.h:173: error: type of formal parameter 3 is incomplete

Clang also fails:

In file included from /usr/src/sys/dev/acpica/acpi_hpet.c:58:
=2E/pcib_if.h:165:61: error: declaration of 'enum pci_id_type' will not b=
e
visible outside of this function [-Werror,-Wvisibility]
typedef int pcib_get_id_t(device_t pcib, device_t dev, enum pci_id_type
type,
                                                            ^
=2E/pcib_if.h:169:38: error: declaration of 'enum pci_id_type' will not b=
e
visible outside of this function [-Werror,-Wvisibility]
                                enum pci_id_type type, uintptr_t *id)
                                     ^
=2E/pcib_if.h:169:50: error: variable has incomplete type 'enum pci_id_ty=
pe'
                                enum pci_id_type type, uintptr_t *id)
                                                 ^
=2E/pcib_if.h:169:38: note: forward declaration of 'enum pci_id_type'
                                enum pci_id_type type, uintptr_t *id)
                                     ^
3 errors generated.

Jung-uk Kim


--gkT1gpbFKCewVB3FHhdWldx0PuEhlWnwK--

--dbepT12CGabjDgX7GV0qt71I7DPxJbh8V
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXM6kjAAoJEHyflib82/FGxisH/2UnSReEe24q8QZG+/dJlwru
rc58uTPMwwOkMMSGSHDwzEgCbKsSLSXd8tQZZkgcdYGuVcqus8GovjAqG//aDl6b
ADugixcHnhHLJjAMyJvNMEATJXwchVC4D24wHfmejmXdhI7ufxrVsxJHvra0VxBM
8BqdZphHBhsLnjec+rGNf+jC3/uaDHM0tpY2Dy1YS4MZno33vVrxdPUtzj0SuJvH
y6IoSuTXYJmwAK++4h4jaOjm2wtddGnfq6Q3UkiYj7MYUvUuj5Gg40NXt8ZuRrFG
lb8ahH1K4VM9crBruXinHNFIoBw/La0k6Ach7YmLPdjIoLWtsj0gi6bLYEAu5xw=
=NVao
-----END PGP SIGNATURE-----

--dbepT12CGabjDgX7GV0qt71I7DPxJbh8V--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?afefe83a-df9c-b2fc-73d0-0e3b3dae6d60>