Date: Sun, 31 Dec 2017 10:06:06 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457632 - in head/lang/guile2: . files Message-ID: <r2rb-qnb5-wny@FreeBSD.org> In-Reply-To: <20171231084028.GA98479@FreeBSD.org> (Alexey Dokuchaev's message of "Sun, 31 Dec 2017 08:40:28 %2B0000") References: <201712301912.vBUJCdtc086342@repo.freebsd.org> <1sjc-ylsz-wny@FreeBSD.org> <20171231084028.GA98479@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev <danfe@FreeBSD.org> writes: > On Sat, Dec 30, 2017 at 09:59:08PM +0100, Jan Beich wrote: > >> Alexey Dokuchaev <danfe@FreeBSD.org> writes: >> >> > ++/* With old GCC, do not override _Static_assert: it conflicts with >> > ++ #include <complex.h> below. */ >> > ++#if __clang__ || (__GNUC__ >= 4 && __GNUC_MINOR__ >= 6) >> >> - GCC check for minor version rejects 5.4, 6.4, 7.2 >> - Clang check needs defined() to pacify -Wundef with GCC >> >> libguile/numbers.c:50:5: warning: "__clang__" is not defined, evaluates >> to 0 [-Wundef] >> #if __clang__ || (__GNUC__ >= 4 && __GNUC_MINOR__ >= 6) >> ^~~~~~~~~ > > How about this: > > #if defined(__clang__) || (__GNUC__ * 10 + __GNUC_MINOR__ >= 46) > ... ? Looks OK. None of lang/gcc* ports have __GNUC_MINOR__ >= 10.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?r2rb-qnb5-wny>