Date: Sat, 23 Jan 2016 07:18:04 +0200 From: Stanislav Galabov <sgalabov@gmail.com> To: Steve Kiernan <stevek@juniper.net> Cc: freebsd-mips@freebsd.org, freebsd-arm@freebsd.org Subject: Re: SPI geom_flashmap/fdt_slicer support, FDT 'resets=' support and a move of ohci_fdt.c Message-ID: <CANiSyhR01wY65%2B2Nu%2B3Hucs%2BbDWyKhH_ejujG9CE39SaQQ2Wqg@mail.gmail.com> In-Reply-To: <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> References: <B4B24B7D-B3EE-4F37-9E89-24FF17294C70@gmail.com> <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
It looks like only part of the original patch I submitted made it into head (only the mx25l part). We also need to change sys/conf/files as Steve pointed out, as well as sys/geom/geom_flashmap.c: https://bz-attachments.freebsd.org/attachment.cgi?id=3D165546 Best wishes, Stanislav On Sat, Jan 23, 2016 at 12:39 AM, Steve Kiernan <stevek@juniper.net> wrote: > On Thu, 14 Jan 2016 11:01:10 +0200 > Stanislav Galabov <sgalabov@gmail.com> wrote: > > > Hi all, > > > > First off, sorry for the cross-post, I wasn=E2=80=99t very sure where t= his > should go=E2=80=A6 > > > > I=E2=80=99ve created 3 PRs, which enable some functionality that my wor= k on > Ralink/Mediatek SoCs would benefit from. > > > > 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206227 > > - This enables geom_flashmap and fdt_slicer support for SPI flash chips > supported by the mx25l driver (sys/dev/flash/mx25l.c) > > I see this change was committed to head, but I don't see a corresponding > change to sys/conf/files to ensure fdt_slicer.c and geom_flashmap.c get > compiled. > > I think you also need something like the following: > > Index: sys/conf/files > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/conf/files (revision 294541) > +++ sys/conf/files (working copy) > @@ -1419,7 +1419,7 @@ > dev/fdt/fdt_common.c optional fdt > dev/fdt/fdt_pinctrl.c optional fdt fdt_pinctrl > dev/fdt/fdt_pinctrl_if.m optional fdt fdt_pinctrl > -dev/fdt/fdt_slicer.c optional fdt cfi | fdt nand > +dev/fdt/fdt_slicer.c optional fdt cfi | fdt nand | fdt mx25l > dev/fdt/fdt_static_dtb.S optional fdt fdt_dtb_static \ > dependency "$S/boot/fdt/dts/${MACHINE}/${FDT_DTS_FILE}" > dev/fdt/simplebus.c optional fdt > @@ -3010,7 +3010,7 @@ > geom/geom_dump.c stfgeom_dumandard > geom/geom_event.c standard > geom/geom_fox.c optional geom_fox > -geom/geom_flashmap.c optional fdt cfi | fdt nand > +geom/geom_flashmap.c optional fdt cfi | fdt nand | fdt mx25l > geom/geom_io.c standard > geom/geom_kern.c standard > geom/geom_map.c optional geom_map >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANiSyhR01wY65%2B2Nu%2B3Hucs%2BbDWyKhH_ejujG9CE39SaQQ2Wqg>