From owner-freebsd-net@FreeBSD.ORG Wed Nov 7 15:36:21 2007 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D26BD16A46E for ; Wed, 7 Nov 2007 15:36:21 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.185]) by mx1.freebsd.org (Postfix) with ESMTP id 5ABF213C4B3 for ; Wed, 7 Nov 2007 15:36:21 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1769806nfb for ; Wed, 07 Nov 2007 07:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; bh=f36KjNu5WhHDYb727/ywOB4sy0zpLZPvLutHDGvS/8Q=; b=hdvOWTuxYr7Xka6TqRM7LdpR1HYbGD4GaVlVl7IDE8PkZoojUS4uVDXzjYjfnf1R1RpV3IIFuPQ6e3OHq4CVIbHrdu/HKk+t2BVATNQKM4I1O8QcxUCxJJY/AtO/Td0H29yU5lh6UeNSbQT5tq1dPC6UOpeUF7CXj5FpLolz9AI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; b=Minr4B0lxEFchAjHUxqD4tLgJWjmCYtICJXrZ9nnLSZ/F+5OX/SFfeS2lx7+bg6CQOp2MojTCW9RGKZPxMHzc1qj6amBaolr1SxdRtVWfmIBDl/sjS+soS5bQSHWK3JzXEH45xF0Q9b4B/IHBCOOYUJtzs06+h61ChpUGfzsrHQ= Received: by 10.86.58.3 with SMTP id g3mr5335571fga.1194449773183; Wed, 07 Nov 2007 07:36:13 -0800 (PST) Received: from ?172.17.0.111? ( [193.136.24.188]) by mx.google.com with ESMTPS id 4sm857282fgg.2007.11.07.07.36.05 (version=SSLv3 cipher=OTHER); Wed, 07 Nov 2007 07:36:06 -0800 (PST) Message-Id: From: Rui Paulo To: Roman Divacky In-Reply-To: <20071107123204.GA30802@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v912) Date: Wed, 7 Nov 2007 15:36:03 +0000 References: <20071105153459.GA52205@freebsd.org> <0AB7127C-ED54-474A-897E-0DB8EF94F42D@FreeBSD.org> <20071107123204.GA30802@freebsd.org> X-Mailer: Apple Mail (2.912) Sender: Rui Paulo Cc: net@FreeBSD.org Subject: Re: [PATCH]: implementation of SIOCGIFINDEX in linuxulator X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2007 15:36:21 -0000 On 7 Nov 2007, at 12:32, Roman Divacky wrote: > On Wed, Nov 07, 2007 at 11:30:34AM +0000, Rui Paulo wrote: >> >> On 5 Nov 2007, at 15:34, Roman Divacky wrote: >> >>> hi >>> >>> I implemented SIOCGIFINDEX in linuxulator and I would like you >>> to review the patch.. the implementation is trivial, just mapping >>> it to the native fbsd call. >>> >>> the patch can be found here: >>> http://www.vlakno.cz/~rdivacky/linux_socket.patch >>> >>> I have a report that it helps some java program. please review it so >>> it can be commited >> >> >> Perhaps I'm missing something, but what should happen with >> LINUX_SIOCGIFCOUNT ? > > it should just return 0. its not implemented in linux and just > returns 0 > there too.. the tester reports that it works in this implementation > so I guess it's just ok. Alright, thanks for the clarification. Your patch looks fine. Regards. -- Rui Paulo