From owner-svn-src-all@freebsd.org Thu Aug 6 03:04:56 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D12189B38FE; Thu, 6 Aug 2015 03:04:56 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B1471E87; Thu, 6 Aug 2015 03:04:56 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by ioeg141 with SMTP id g141so68699979ioe.3; Wed, 05 Aug 2015 20:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0j+E3v4NHWke8XlFBZHGpa4szQJoLEkZzxLGWHg3jI4=; b=X3e2MKJyih0dFwUWrDa3siJAPL302PpM4CQf1FVO7dMmfW03yjhWlWyvF1m1mbVxbr gauLH+r9LDrwg4HdzLJe9bhgBOmvNwl63jNKQ9JX9rQtV3IKHiiiQVnbVNckumuAl1qE U4+QeLWVkG8rWQcj/R2N3cLmhOXgCjS1Lek5OzIoP+rpMxSalm5dGu/h1/4YpwTibPv3 Vrw5mTSutUoxys/Va1ykE0SZjubdtgcXHtAesgqi8W5r1HIsC4nQee1A32PpVg2YlIKx J3aO3gzQaVdJQp62OzZxBmVa6TMOet88LYcGq5PHj97M8yLrQMoFLUigSr85nGJvnC3l NI4w== MIME-Version: 1.0 X-Received: by 10.107.132.215 with SMTP id o84mr14911033ioi.36.1438830295949; Wed, 05 Aug 2015 20:04:55 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.36.29.193 with HTTP; Wed, 5 Aug 2015 20:04:55 -0700 (PDT) In-Reply-To: <20150806022247.GG1484@FreeBSD.org> References: <201507020832.t628W3WJ002944@repo.freebsd.org> <55BF6A84.1040808@FreeBSD.org> <20150806021723.GB72832@garage.freebsd.pl> <20150806022247.GG1484@FreeBSD.org> Date: Wed, 5 Aug 2015 20:04:55 -0700 X-Google-Sender-Auth: hAay4WPloHw4m2lbLaJv7el4gdI Message-ID: Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: "K. Macy" To: Glen Barber Cc: Pawel Jakub Dawidek , Andriy Gapon , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Xin Li Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 03:04:56 -0000 His proposed solution looks fine to me. Why don't we commit that? -K On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber wrote: > On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: >> On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: >> > On 30/07/2015 10:24, K. Macy wrote: >> > > Just FYI this change introduces a deadlock with with the >> > > spa_namespace_lock. Mount will be holding this lock while trying to >> > > acquire the spa_namespace_lock. zfskern on the other hand holds the >> > > spa_namespace_lock when calling zfs_freebsd_access which in turn >> > > tries to acquire the teardown lock. >> > >> > I missed the fact that zpool.cache file is being written with spa_namespace_lock >> > held. >> > I'll try to either resolve the problem in the next day or I will revert the change. >> >> FYI, I'm hitting this deadlock on my laptop. Reverting the change fixes >> the problem. >> > > Since it is now 3 days after "I'll try to either resolve the problem in > the next day or I will revert the change", my view is that this needs to > be reverted now, if it hasn't been done already. > > Glen >