Date: Sun, 22 Aug 2010 21:29:12 -0400 From: John Nielsen <john@jnielsen.net> To: "gshapiro@freebsd.org" <gshapiro@freebsd.org> Cc: FreeBSD Stable <freebsd-stable@freebsd.org>, Stefan Bethke <stb@lassitu.de> Subject: Re: Apparent dnsbl bug in Sendmail or m4 Message-ID: <3E7350F2-5295-4D83-B807-C7F2246F9D2C@jnielsen.net> In-Reply-To: <CABA9DBB-D584-491F-AE6E-14A5C862B8EF@jnielsen.net> References: <20100822031045.sl4d10544k0s80kw@newwebmail.jnielsen.net> <CD37C0F6-F202-4941-A740-BF17358270A5@lassitu.de> <B6617274-729C-42F3-AC70-7FB81B16EEC4@lassitu.de> <CABA9DBB-D584-491F-AE6E-14A5C862B8EF@jnielsen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
It was pointed out to me that the example in freebsd.mc has been double-quot=
ed for some time. That's what I get for carrying old config files around for=
too long I suppose. Sorry for the noise and thanks again all for the prompt=
replies.
On Aug 22, 2010, at 3:48 PM, John Nielsen <lists@jnielsen.net> wrote:
> On Aug 22, 2010, at 6:40 AM, Stefan Bethke wrote:
>=20
>> Am 22.08.2010 um 10:00 schrieb Stefan Bethke:
>>=20
>>> FEATURE(`dnsbl', `bl.spamcop.net', `"550 " $&{client_addr} "foo" $&{clie=
nt_addr} ""')dnl
>>=20
>> The real culprit is the comma. I believe the problem stems from unquoted=
use of the arguments in some of the ifelses, where the comma turns the sing=
le argument into two.
>=20
> That makes a lot of sense, especially when combined with the off-list sugg=
estions I got to double-quote the error message.
>=20
>> Tracing the ifelses with -d aceq I see this for the last ifelse in cf/fea=
ture/dnsbl.m4:
>>=20
>> m4trace: -1- ifelse(`X"550 Mail from " $&{client_addr} " rejected', `see h=
ttp://spamcop.net/bl.shtml?" $&{client_addr}', `Xquarantine', `R<?>$+ =
$#error $@ quarantine $: _DNSBL_SRV_', `X"550 Mail from " $&{client_addr} "=
rejected', `
>> see http://spamcop.net/bl.shtml?" $&{client_addr}', `Xdiscard', `R<?>$+ =
=20
>> $#discard $: _DNSBL_SRV_', `R<?>$+ $#error $@ 5.7.1 $: _DNSB=
L_MSG_'
>> ) -> ???
>> m4trace: -1- ifelse(...) -> `'
>> m4trace: -1- ifelse ...
>>=20
>>=20
>> I've never managed to really wrap my head around m4 quoting, but the easy=
fix is to use some other character that has no meaning to m4.
>=20
> The fact that you knew how to do a trace shows that you're way ahead of me=
in grokking m4. :) I can confirm that replacing the comma with a colon make=
s the problem go away.
>=20
> Does someone with some m4-fu want to take a stab at producing a fix? The p=
roblem appears in the 7-arg "ifelse" in the last few lines of /usr/share/sen=
dmail/cf/feature/dnsbl.m4, though the source could of course be missing quot=
es earlier in the file.
>=20
> I'd be happy to test any proposed patches and submit a bug report to Sendm=
ail if appropriate. At the very least perhaps the example in the comment of /=
etc/mail/freebsd.mc should be modified to not use a comma.
>=20
> Thanks!
>=20
> JN
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E7350F2-5295-4D83-B807-C7F2246F9D2C>