Date: Thu, 5 Sep 2013 16:40:01 GMT From: Mark Felder <feld@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/181341: [patch] daemon(8): ability to write pidfile for itself Message-ID: <201309051640.r85Ge1tq021202@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/181341; it has been noted by GNATS. From: Mark Felder <feld@FreeBSD.org> To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/181341: [patch] daemon(8): ability to write pidfile for itself Date: Thu, 05 Sep 2013 11:36:06 -0500 This is a multi-part message in MIME format. --_----------=_1378398966221370 Content-Transfer-Encoding: 7bit Content-Type: text/plain updated patch with some changes suggested by jmg@ --_----------=_1378398966221370 Content-Disposition: attachment; filename="daemon.diff" Content-Id: <1378398963.21962.10bf27b601ae77f55bca374e7d0c8f551230d9cc.033E93E8@messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name="daemon.diff" SW5kZXg6IGRhZW1vbi44Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRh ZW1vbi44CShyZXZpc2lvbiAyNTQzMjUpCisrKyBkYWVtb24uOAkod29ya2lu ZyBjb3B5KQpAQCAtMzUsNyArMzUsOCBAQAogLlNoIFNZTk9QU0lTCiAuTm0K IC5PcCBGbCBjZnIKLS5PcCBGbCBwIEFyIHBpZGZpbGUKKy5PcCBGbCBwIEFy IGNoaWxkX3BpZGZpbGUKKy5PcCBGbCBQIEFyIHN1cGVydmlzb3JfcGlkZmls ZQogLk9wIEZsIHUgQXIgdXNlcgogLkFyIGNvbW1hbmQgYXJndW1lbnRzIC4u LgogLlNoIERFU0NSSVBUSU9OCkBAIC03MSw2ICs3MiwyNiBAQAogcmVnYXJk bGVzcyBvZiB3aGV0aGVyIHRoZQogLkZsIHUKIG9wdGlvbiBpcyB1c2VkIG9y IG5vdC4KKy5JdCBGbCBQIEFyIGZpbGUKK1dyaXRlIHRoZSBJRCBvZiB0aGUg CisuTm0KK3Byb2Nlc3MgaW50byB0aGUKKy5BciBmaWxlCit1c2luZyB0aGUK Ky5YciBwaWRmaWxlIDMKK2Z1bmN0aW9uYWxpdHkuCitUaGUgcHJvZ3JhbSBp cyBleGVjdXRlZCBpbiBhIHNwYXduZWQgY2hpbGQgcHJvY2VzcyB3aGlsZSB0 aGUKKy5ObQord2FpdHMgdW50aWwgaXQgdGVybWluYXRlcyB0byBrZWVwIHRo ZQorLkFyIGZpbGUKK2xvY2tlZCBhbmQgcmVtb3ZlcyBpdCBhZnRlciB0aGUg cHJvY2VzcyBleGl0cy4KK1RoZQorLkFyIGZpbGUKK293bmVyIGlzIHRoZSB1 c2VyIHdobyBydW5zIHRoZQorLk5tCityZWdhcmRsZXNzIG9mIHdoZXRoZXIg dGhlCisuRmwgdQorb3B0aW9uIGlzIHVzZWQgb3Igbm90LgogLkl0IEZsIHIK IFN1cGVydmlzZSBhbmQgcmVzdGFydCB0aGUgcHJvZ3JhbSBpZiBpdCBoYXMg YmVlbiB0ZXJtaW5hdGVkLgogLkl0IEZsIHUgQXIgdXNlcgpAQCAtNzksNyAr MTAwLDggQEAKIC5FbAogLlBwCiBJZiB0aGUKLS5GbCBwCisuRmwgcCAsCisu RmwgUAogb3IKIC5GbCByCiBvcHRpb24gaXMgc3BlY2lmaWVkIHRoZSBwcm9n cmFtIGlzIGV4ZWN1dGVkIGluIGEgc3Bhd25lZCBjaGlsZCBwcm9jZXNzLgpA QCAtOTMsNiArMTE1LDI1IEBACiBzcGF3bmVkIHByb2Nlc3MuCiBOb3JtYWxs eSBpdCB3aWxsIGNhdXNlIHRoZSBjaGlsZCB0byBleGl0IGZvbGxvd2VkIGJ5 IHRoZSB0ZXJtaW5hdGlvbgogb2YgdGhlIHN1cGVydmlzaW5nIHByb2Nlc3Mg YWZ0ZXIgcmVtb3ZpbmcgdGhlIHBpZGZpbGUuCisuUHAKK1RoZQorLkZsIFAK K29wdGlvbiBpcyB1c2VmdWwgY29tYmluZWQgd2l0aCB0aGUKKy5GbCByCitv cHRpb24gYXMgdGhlIHBpZGZpbGUgY29udGFpbnMgdGhlIElEIG9mIHRoZSBz dXBlcnZpc29yCitub3QgdGhlIGNoaWxkLiBUaGlzIGlzIGVzcGVjaWFsbHkg aW1wb3J0YW50IGlmIHlvdSB1c2UKKy5GbCByCitpbiBhbiByYyBzY3JpcHQg YXMgdGhlCisuRmwgcAorb3B0aW9uIHdpbGwgZ2l2ZSB5b3UgdGhlIGNoaWxk J3MgSUQgdG8gc2lnbmFsIHdoZW4geW91IGF0dGVtcHQgdG8KK3N0b3AgdGhl IHNlcnZpY2UsIGNhdXNpbmcgCisuTm0KK3RvIHJlc3RhcnQgdGhlIGNoaWxk LiBJZiB0aGUgSUQgd3JpdHRlbiBieSB0aGUKKy5GbCBQCitvcHRpb24gaXMg c2lnbmFsbGVkLAorLk5tCit3aWxsIGNhdXNlIHRoZSBjaGlsZCB0byBleGl0 IGZvbGxvd2VkIGJ5IHRoZSB0ZXJtaW5hdGlvbiBvZiB0aGUKK3N1cGVydmlz aW5nIHByb2Nlc3MgYWZ0ZXIgcmVtb3ZpbmcgdGhlIHBpZGZpbGUuCiAuU2gg RVhJVCBTVEFUVVMKIFRoZQogLk5tCkluZGV4OiBkYWVtb24uYwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBkYWVtb24uYwkocmV2aXNpb24gMjU0MzI1 KQorKysgZGFlbW9uLmMJKHdvcmtpbmcgY29weSkKQEAgLTUzLDE2ICs1Mywx NyBAQAogaW50CiBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiB7Ci0J c3RydWN0IHBpZGZoICpwZmggPSBOVUxMOworCXN0cnVjdCBwaWRmaCAgKnBw ZmgsICpwZmg7CiAJc2lnc2V0X3QgbWFzaywgb2xkbWFzazsKIAlpbnQgY2gs IG5vY2hkaXIsIG5vY2xvc2UsIHJlc3RhcnQ7Ci0JY29uc3QgY2hhciAqcGlk ZmlsZSwgKnVzZXI7CisJY29uc3QgY2hhciAqcGlkZmlsZSwgKnBwaWRmaWxl LCAgKnVzZXI7CiAJcGlkX3Qgb3RoZXJwaWQsIHBpZDsKIAogCW5vY2hkaXIg PSBub2Nsb3NlID0gMTsKIAlyZXN0YXJ0ID0gMDsKLQlwaWRmaWxlID0gdXNl ciA9IE5VTEw7Ci0Jd2hpbGUgKChjaCA9IGdldG9wdChhcmdjLCBhcmd2LCAi Y2ZwOnJ1OiIpKSAhPSAtMSkgeworCXBwZmggPSBwZmggPSBOVUxMOworCXBw aWRmaWxlID0gcGlkZmlsZSA9IHVzZXIgPSBOVUxMOworCXdoaWxlICgoY2gg PSBnZXRvcHQoYXJnYywgYXJndiwgImNmcDpQOnJ1OiIpKSAhPSAtMSkgewog CQlzd2l0Y2ggKGNoKSB7CiAJCWNhc2UgJ2MnOgogCQkJbm9jaGRpciA9IDA7 CkBAIC03Myw2ICs3NCw5IEBACiAJCWNhc2UgJ3AnOgogCQkJcGlkZmlsZSA9 IG9wdGFyZzsKIAkJCWJyZWFrOworCQljYXNlICdQJzoKKwkJCXBwaWRmaWxl ID0gb3B0YXJnOworCQkJYnJlYWs7CiAJCWNhc2UgJ3InOgogCQkJcmVzdGFy dCA9IDE7CiAJCQlicmVhazsKQEAgLTg5LDcgKzkzLDcgQEAKIAlpZiAoYXJn YyA9PSAwKQogCQl1c2FnZSgpOwogCi0JcGZoID0gTlVMTDsKKwlwcGZoID0g cGZoID0gTlVMTDsKIAkvKgogCSAqIFRyeSB0byBvcGVuIHRoZSBwaWRmaWxl IGJlZm9yZSBjYWxsaW5nIGRhZW1vbigzKSwKIAkgKiB0byBiZSBhYmxlIHRv IHJlcG9ydCB0aGUgZXJyb3IgaW50ZWxsaWdlbnRseQpAQCAtMTA0LDYgKzEw OCwxOCBAQAogCQkJZXJyKDIsICJwaWRmaWxlIGBgJXMnJyIsIHBpZGZpbGUp OwogCQl9CiAJfQorCQorCS8qIGRvIHNhbWUgZm9yIGFjdHVhbCBkYWVtb24g cHJvY2VzcyAqLworCWlmIChwcGlkZmlsZSAhPSBOVUxMKSB7CisJCXBwZmgg PSBwaWRmaWxlX29wZW4ocHBpZGZpbGUsIDA2MDAsICZvdGhlcnBpZCk7CisJ CWlmIChwcGZoID09IE5VTEwpIHsKKwkJCWlmIChlcnJubyA9PSBFRVhJU1Qp IHsKKwkJCQllcnJ4KDMsICJwcm9jZXNzIGFscmVhZHkgcnVubmluZywgcGlk OiAlZCIsCisJCQkJICAgICBvdGhlcnBpZCk7CisJCQl9CisJCQllcnIoMiwg InBwaWRmaWxlIGBgJXMnJyIsIHBwaWRmaWxlKTsKKwkJfQorCX0KIAogCWlm IChkYWVtb24obm9jaGRpciwgbm9jbG9zZSkgPT0gLTEpCiAJCWVycigxLCBO VUxMKTsKQEAgLTE3Niw2ICsxOTIsMTAgQEAKIAkJICovCiAJCWVycigxLCAi JXMiLCBhcmd2WzBdKTsKIAl9CisJLyogd3JpdGUgb3V0IHBhcmVudCBwaWRm aWxlIGlmIG5lZWRlZCAqLworCWlmIChwcGlkZmlsZSAhPSBOVUxMKQorCQlw aWRmaWxlX3dyaXRlKHBwZmgpOworCiAJc2V0cHJvY3RpdGxlKCIlc1slZF0i LCBhcmd2WzBdLCBwaWQpOwogCWlmICh3YWl0X2NoaWxkKHBpZCwgJm1hc2sp ID09IDAgJiYgcmVzdGFydCkgewogCQlzbGVlcCgxKTsKQEAgLTE4Miw2ICsy MDIsNyBAQAogCQlnb3RvIHJlc3RhcnQ7CiAJfQogCXBpZGZpbGVfcmVtb3Zl KHBmaCk7CisJcGlkZmlsZV9yZW1vdmUocHBmaCk7CiAJZXhpdCgwKTsgLyog RXhpdCBzdGF0dXMgZG9lcyBub3QgbWF0dGVyLiAqLwogfQogCkBAIC0yNDAs NyArMjYxLDcgQEAKIHVzYWdlKHZvaWQpCiB7CiAJKHZvaWQpZnByaW50Zihz dGRlcnIsCi0JICAgICJ1c2FnZTogZGFlbW9uIFstY2ZyXSBbLXAgcGlkZmls ZV0gWy11IHVzZXJdIGNvbW1hbmQgIgorCSAgICAidXNhZ2U6IGRhZW1vbiBb LWNmcl0gWy1wIGNoaWxkX3BpZGZpbGVdIFstUCBzdXBlcnZpc29yX3BpZGZp bGVdIFstdSB1c2VyXSBjb21tYW5kICIKIAkJImFyZ3VtZW50cyAuLi5cbiIp OwogCWV4aXQoMSk7CiB9Cg== --_----------=_1378398966221370--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309051640.r85Ge1tq021202>