From owner-freebsd-ports-bugs@freebsd.org  Fri Feb 19 11:52:00 2016
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E209BAAC50B
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Fri, 19 Feb 2016 11:52:00 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D19B91282
 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 19 Feb 2016 11:52:00 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u1JBq0wU022865
 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 19 Feb 2016 11:52:00 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 207299] print/muttprint: Update to 0.73
Date: Fri, 19 Feb 2016 11:52:01 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: needs-patch, needs-qa
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: rakuco@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-207299-13-dZFD4XR7AI@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-207299-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-207299-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Feb 2016 11:52:01 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207299

--- Comment #8 from Raphael Kubo da Costa <rakuco@FreeBSD.org> ---
Questions I have about the patch:
- Can't you avoid patching Makefile.am if you just install the additional
documentation files yourself in the post-install target?
- Why are the translated man pages not being installed?
- Does doc/manpages/en/muttprint.pod as-is cause build issues?
- Is installing the original files listed in pics/Makefile.am a problem? If
not, you could get rid of the patch and just install Beastie.eps in
post-install.

And something to consider but not exactly urgent:
- You should convert checks for certain options to options helpers. For
example:
  .if ${PORT_OPTIONS:MX11}
  RUN_DEPENDS+=3D convert:${PORTSDIR}/graphics/ImageMagick
  .else
  RUN_DEPENDS+=3D   convert:${PORTSDIR}/graphics/ImageMagick-nox11
  .endif

  becomes

  X11_RUN_DEPENDS=3Dconvert:${PORTSDIR}/graphics/ImageMagick
  X11_RUN_DEPENDS_OFF=3Dconvert:${PORTSDIR}/graphics/ImageMagick-nox11
- The same applies to options helpers in targets. Fore xample:
  post-patch:
  # ...
  .if ${PORT_OPTIONS:MCUPS}
    @${REINPLACE_CMD} 's|lpr $$CUPS_OPTIONS|${PREFIX}/bin/lpr $$CUPS_OPTION=
S|'
${WRKSRC}/muttprint
  .endif

  becomes

  post-patch-CUPS-on:
    @${REINPLACE_CMD} 's|lpr $$CUPS_OPTIONS|${PREFIX}/bin/lpr $$CUPS_OPTION=
S|'
${WRKSRC}/muttprint

--=20
You are receiving this mail because:
You are the assignee for the bug.=